I can see in the code how this would happen, but I can't personally reproduce this. If I have no local notifications, the page loads with "local" wiki as [ 0 ] and then shows me all notifications (which are unread)
I even marked everything as read in my remote wikis, and still loaded a full JS page with "local" source marking , no foreign sources in the sidebar, and the list of read notifications from the local source showing.
Code-wise, this fix looks perfectly fine, so I'm leaning towards merging it even just for code consistency, but I'm slightly worried I couldn't reproduce the bug first, in case this exposes followup issues; am I missing something?
It was hard to reproduce for me, because my local wiki sends out a 'welcome' notification
Yes, the wiki in which a fresh user created an account would receive 'Welcome', but on another wiki there will be zero notifications.
Checked in betalabs - looks fine.
If cross-wiki notification is turned off - still 'No notifications' is displayed