Remove $wgExperimentalHtmlIds (deprecated in 1.30)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Danny_B
	Jul 8 2016, 1:13 PM

Description

$wgExperimentalHtmlIds has been introduced in 1.16, but almost immediately turned off by default as there were several complaints on its behavior.

It probably does not make sense to keep it.

Details

	Subject	Repo	Branch	Lines +/-
	Remove $wgExperimentalHtmlIds and related code, deprecated in 1.30	mediawiki/core	master	+12 -89
	Set default fragment mode to [ 'legacy', 'html5' ]	mediawiki/core	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned In: T186267: Phase out legacy IDs now that HTML5 IDs are deployed everywhere
T172545: Redirect handling of hash fragments is incorrect
Mentioned Here: rMWfd6e9ef2d481: Human-readable section ID support

Event Timeline

Danny_B created this task.Jul 8 2016, 1:13 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 8 2016, 1:13 PM

Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jul 8 2016, 2:05 PM

Krinkle updated the task description. (Show Details)Jul 16 2016, 1:23 AM

Jdlrobson added a parent task: T172545: Redirect handling of hash fragments is incorrect.Aug 7 2017, 3:20 PM

It was deprecated by @MaxSem in rMWfd6e9ef2d481: Human-readable section ID support. Thanks to the deprecation policy we can't actually remove it until 1.31 or later.

Possibly someone should add a wfDeprecated() into the bit in Setup.php.

Anomie removed a parent task: T172545: Redirect handling of hash fragments is incorrect.Aug 7 2017, 8:31 PM

Anomie mentioned this in T172545: Redirect handling of hash fragments is incorrect.Aug 7 2017, 8:36 PM

Change 405391 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] Set default fragment mode to [ 'legacy', 'html5' ]

https://gerrit.wikimedia.org/r/405391

gerritbot added a project: Patch-For-Review.Jan 20 2018, 2:39 AM

Change 405391 merged by jenkins-bot:
[mediawiki/core@master] Set default fragment mode to [ 'legacy', 'html5' ]

https://gerrit.wikimedia.org/r/405391

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 22 2018, 8:00 PM

cscott mentioned this in T186267: Phase out legacy IDs now that HTML5 IDs are deployed everywhere.Feb 1 2018, 10:02 PM

Krinkle renamed this task from Kill $wgExperimentalHtmlIds to Remove $wgExperimentalHtmlIds (deprecated in 1.30).Mar 22 2018, 1:34 AM

Krinkle triaged this task as Low priority.

Krinkle edited projects, added MW-1.31-release; removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review.

TerraCodes subscribed.Apr 3 2018, 7:55 AM

Change 425582 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Remove $wgExperimentalHtmlIds and related code, deprecated in 1.30

https://gerrit.wikimedia.org/r/425582

gerritbot added a project: Patch-For-Review.Apr 11 2018, 6:17 PM