Page MenuHomePhabricator

"Special:Notifications" has a display problem in some languages
Closed, ResolvedPublic

Description

When you go to [[Special:Notifications]], you see a box saying "Recent activity". You also see the text "Pages with unread notifications".

The text Pages with unread notifications should appear beneath the title Recent activity.

However, on some languages, such as Hebrew (rtl language), Japanese, Chinese and more, there is a problem. The text Pages with unread notifications appears next to the title, instead of appearing beneath the title. This bug results a very ugly design.

I've attached three screenshots:
The first one shows how it should be (on English interface);
the second one shows the problem on Japanese interface;
and the last one shows the problem on Hebrew interface (which is an RTL language).

BTW: There's another minor bug: The name of the project, as written in this box, should change in accordance with the uselang=xx in the URL. Currently, it always appears in the "real" language the user has chosen on their preferences, and it ignores uselang=xx.



Event Timeline

Guycn2 created this task.Jul 8 2016, 10:53 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 8 2016, 10:53 PM

Change 298107 had a related patch set uploaded (by Mooeypoo):
Make sure sidebar titles are under one another in Special:Notifications

https://gerrit.wikimedia.org/r/298107

Mooeypoo claimed this task.Jul 8 2016, 11:02 PM
Mooeypoo added subscribers: Amire80, Mooeypoo.

Whoops, good find. Thanks for reporting!

Thank you for fixing it ;)

Change 298113 had a related patch set uploaded (by Mooeypoo):
Use 'uselang' when fetching unread page notifications

https://gerrit.wikimedia.org/r/298113

Change 298113 merged by jenkins-bot:
Use 'uselang' when fetching unread page notifications

https://gerrit.wikimedia.org/r/298113

Change 298107 merged by jenkins-bot:
Make sure sidebar titles are under one another in Special:Notifications

https://gerrit.wikimedia.org/r/298107

Checked in betalabs - 'Recent activity'

  • zhwiki and hewiki show 'Recent activity' and the label 'Pages with unread notifications' properly placed.

  • uselang works in betalabs too

Example from production BEFORE the fix:

Checked in betalabs - 'Recent activity'

  • zhwiki and hewiki show 'Recent activity' and the label 'Pages with unread notifications' properly placed.


  • uselang works in betalabs too

Example from production BEFORE the fix:

Thanks;)

jmatazzoni closed this task as Resolved.Jul 12 2016, 6:04 PM