Bad output of AbuseFilter blocks in CU get edits
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarcoAurelio
	Jul 8 2016, 11:57 PM

Description

When getting edits on CU, AbuseFilter blocks shows as:

(Logs) . . 23:14 . . Abuse filter (talk | contribs | block) (administrator) Abuse filter blocked <USERNAME> with an expiration time of <span class='blockExpiry' title='‎indefinite'>infinite</span> (account creation disabled) (Automatically blocked by abuse filter. Description of matched rule: Specific user page spam)

The bold text is the weird output. If possible, please fix. Thank you.

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T340995 Display client hint data in Special:Investigate
Resolved		Dreamy_Jazz	T139809 Bad output of AbuseFilter blocks in CU get edits
Open		Dreamy_Jazz	T145265 Store check user data action text in structured format
Duplicate		None	T154796 Flow links formatting fail on Special:CheckUser
Open	Feature	Dreamy_Jazz	T324907 Create separate tables for log events in CheckUser
Resolved		Ladsgroup	T326105 Create cu_log_event and cu_private_event on WMF wikis
Resolved		Milimetric	T327447 FYI: Other changes to the CheckUser tables
Open		None	T341829 Enable read new for the event table migration
Resolved		Dreamy_Jazz	T330158 Enable write new for the event table migration
Resolved		Dreamy_Jazz	T328874 Create temporary column in cu_changes to assist in migration to the new tables
Resolved		• Marostegui	T329203 Add new column cuc_only_for_read_old to cu_changes for migration purposes to wmf wikis
Resolved	PRODUCTION ERROR	Dreamy_Jazz	T342902 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cuc_only_for_read_old' in 'field list'Function: MediaWiki\CheckUser\Hooks::onAuthManagerLoginAuthenticateAuditQuery: INSERT INTO `cu_changes` (cuc_page_id,cuc_namespac
Resolved		• Marostegui	T343174 Add missing column cuc_only_for_read_old to testcommonswiki
Open		Dreamy_Jazz	T328992 Add read new support to Special:CheckUser for event table migration
Open		Dreamy_Jazz	T328995 Enable read new support in Special:CheckUser's 'Get edits' mode
Resolved	BUG REPORT	Dreamy_Jazz	T347773 Log action text shown when reading new does not respect the deleted status of the log
Resolved		Dreamy_Jazz	T328997 Enable read new support in Special:CheckUser's 'Get users' mode
Open		Dreamy_Jazz	T328998 Enable read new support in Special:CheckUser's 'Get IP Addresses' mode
Open		None	T329189 Add read new support to Special:Investigate for event table migration
Open		None	T329200 Enable read new support in Special:Investigate's 'Timeline' tab
Open		None	T329201 Enable read new support in Special:Investigate's 'IPs & User agents' tab
Resolved		Dreamy_Jazz	T328988 Create a SelectQueryBuilder that allows selecting from all three tables
Open		Dreamy_Jazz	T347102 Alias column names in Special:Investigate to not include the "cuc_" prefix
Open		None	T341827 Add read new support to the CheckUser API
Resolved		Dreamy_Jazz	T342629 Investigate CheckUser currently saving failed login attempted to usernames which fail RIGOR_VALID
Open		Dreamy_Jazz	T341688 Create LogFormatter for cu_private_event log events
Resolved	BUG REPORT	Dreamy_Jazz	T347400 Read new cannot parse the log_params of global block log entries
Open		Dreamy_Jazz	T341830 Create maintenance script to delete entries only for read old
Resolved		Dreamy_Jazz	T341586 Allow write old and new for event table migration
Resolved		Dreamy_Jazz	T341934 Failing tests for CheckUser when event table migration config set to WRITE_BOTH and READ_NEW
Resolved		Dreamy_Jazz	T342371 Create a maintenance script used only for testing to insert a large volume of testing actions to CheckUser
Open	PRODUCTION ERROR	pmiazga	T343983 Error: Call to a member function getTimestamp() on null
Open		None	T346022 How does wgCheckUserLogAdditionalRights affect read new for event table migration
Open		Dreamy_Jazz	T346044 Remove CheckUserUnionQueryBuilder

Event Timeline

MarcoAurelio created this task.Jul 8 2016, 11:57 PM

Restricted Application added subscribers: Zppix, JEumerus, Aklapper. · View Herald TranscriptJul 8 2016, 11:57 PM

MarcoAurelio mentioned this in T139810: RFC: Overhaul the CheckUser extension.Jul 23 2016, 1:26 PM

We would probably need to have a modern table with different computer-readable data for generating the line properly instead of inserting the action text and showing it using Linker. See also T41013.

Liuxinyu970226 added a subscriber: Liuxinyu970226.Jul 27 2016, 3:27 AM

Glaisher added a parent task: T145265: Store check user data action text in structured format.Sep 10 2016, 8:16 AM

It is also related to T21964: the logs stored in CU logs table are stored as plain text and are not parsed.

One alternative is to store them as wikitext (with $1, etc) but then parsing them would be an issue.

The second alternative is to store the HTML output of the log, but if the log translation or format changes later, the old format would be shown in CU output (same issue exists now too).

The third (and in my humble opinion, best) option is to store a link to the log id only, and then expand CU code such that using the log id and log parameters it would create the log text on the fly.

MarcoAurelio added a project: AbuseFilter.Dec 13 2016, 10:29 PM

MarcoAurelio moved this task from Backlog to Logging on the AbuseFilter board.

Matanya moved this task from Untriaged to Medium priority on the Stewards-and-global-tools board.Apr 19 2017, 7:58 PM

Meno25 added a subscriber: Meno25.Apr 30 2019, 1:15 PM

Dreamy_Jazz removed a parent task: T145265: Store check user data action text in structured format.Jun 27 2022, 12:18 AM

Dreamy_Jazz added a subtask: T145265: Store check user data action text in structured format.