Page MenuHomePhabricator

Bad output of AbuseFilter blocks in CU get edits
Open, NormalPublic

Description

When getting edits on CU, AbuseFilter blocks shows as:

  • (Logs) . . 23:14 . . Abuse filter (talk | contribs | block) (administrator) Abuse filter blocked <USERNAME> with an expiration time of <span class='blockExpiry' title='‎indefinite'>infinite</span> (account creation disabled) (Automatically blocked by abuse filter. Description of matched rule: Specific user page spam)

The bold text is the weird output. If possible, please fix. Thank you.

Event Timeline

Restricted Application added subscribers: Zppix, JEumerus, Aklapper. · View Herald TranscriptJul 8 2016, 11:57 PM

We would probably need to have a modern table with different computer-readable data for generating the line properly instead of inserting the action text and showing it using Linker. See also T41013.

Huji added a subscriber: Huji.Sep 10 2016, 10:01 PM

It is also related to T21964: the logs stored in CU logs table are stored as plain text and are not parsed.

One alternative is to store them as wikitext (with $1, etc) but then parsing them would be an issue.

The second alternative is to store the HTML output of the log, but if the log translation or format changes later, the old format would be shown in CU output (same issue exists now too).

The third (and in my humble opinion, best) option is to store a link to the log id only, and then expand CU code such that using the log id and log parameters it would create the log text on the fly.

MarcoAurelio moved this task from Backlog to Logging on the AbuseFilter board.
Meno25 added a subscriber: Meno25.Apr 30 2019, 1:15 PM