Page MenuHomePhabricator
Create Task
Maniphest T139930

[Regression] Linking to a specific page revision in mobile, interface elements are repeated
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Linking to a specific page revision in mobile, interface elements like Revision-info-current are repeated one more time

https://en.m.wikipedia.org/w/index.php?title=Nazareth_(band)&oldid=727746720

https://el.m.wikipedia.org/w/index.php?title=%CE%92%CE%B9%CE%BA%CE%B9%CF%80%CE%B1%CE%AF%CE%B4%CE%B5%CE%B9%CE%B1:%CE%A0%CF%81%CF%8C%CF%87%CE%B5%CE%B9%CF%81%CE%BF&oldid=5932344&uselang=qqx

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+6 -11Do not wrap entire subtitle on diff pages in a warning box
mediawiki/coremaster+6 -6Wrap revision info and nav in a div for easy formatting in MobileFrontend
mediawiki/extensions/MobileFrontendmaster+7 -24Do not show the revision info twice
Customize query in gerrit

Event Timeline

geraki created this task.Jul 11 2016, 11:51 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 11 2016, 11:51 AM
• jhobs added a project: Readers-Web-Backlog.Jul 11 2016, 5:08 PM
Jdlrobson renamed this task from Linking to a specific page revision in mobile, interface elements are repeated to Regression: Linking to a specific page revision in mobile, interface elements are repeated.Jul 11 2016, 5:08 PM
Jdlrobson added a project: Regression.
Jdlrobson triaged this task as High priority.Jul 11 2016, 5:13 PM
• jhobs moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.Jul 11 2016, 5:13 PM
Jdlrobson added a project: good first task.Jul 11 2016, 5:13 PM
Jdlrobson added a subscriber: Jdlrobson.

This appears to be a new regression. It didn't used to do that. Should be easy to fix.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJul 11 2016, 5:13 PM
MBinder_WMF renamed this task from Regression: Linking to a specific page revision in mobile, interface elements are repeated to [Regression] Linking to a specific page revision in mobile, interface elements are repeated.Jul 25 2016, 4:56 PM
MBinder_WMF added a project: Reading-Web-Sprint-78-Terminal-Velocity.
MBinder_WMF set the point value for this task to 2.
MBinder_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-78-Terminal-Velocity board.
MBinder_WMF moved this task from Triaged but Future to 2016-17 Q2 on the Readers-Web-Backlog board.
MBinder_WMF moved this task from 2016-17 Q2 to 2016-17 Q1 on the Readers-Web-Backlog board.Aug 1 2016, 4:43 PM
bmansurov claimed this task.Aug 1 2016, 6:30 PM
bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-78-Terminal-Velocity board.
gerritbot added a subscriber: gerritbot.Aug 1 2016, 7:04 PM

Change 302296 had a related patch set uploaded (by Bmansurov):
Do not show the revision info twice

https://gerrit.wikimedia.org/r/302296

bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 1 2016, 7:04 PM
Jdlrobson added a comment.Aug 1 2016, 8:26 PM

@bmansurov's patch fixes this problem but introduces a less severe regression which I think should be fixed as part of solving this bug (I would have -1ed the patch but I felt it was a step in the right direction).

The breadcrumbs now appear in the warning box even though they are not a warning.


To replicate:

  • Put $wgNamespacesWithSubpages[0] = true; in LocalSettings.php
  • Create page "Breadcrumbs"
  • Create page "Breadcrumbs/2"
  • Edit "Breadcrumbs/2"
  • View "Breadcrumbs/2" with the first revision
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 1 2016, 8:26 PM
bmansurov moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 1 2016, 8:27 PM
gerritbot added a comment.Aug 1 2016, 8:34 PM

Change 302296 merged by jenkins-bot:
Do not show the revision info twice

https://gerrit.wikimedia.org/r/302296

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Aug 1 2016, 9:00 PM
bmansurov added a subscriber: • Nirzar.Aug 2 2016, 4:41 AM

@Nirzar what do you think about the screenshot at T139930#2513005? Should we not wrap the revision info in a warning box? The content doesn't seem like it's a warning.

Compare before:


with after:

• Nirzar added a comment.Aug 2 2016, 4:45 AM

As long as warning box has neutral styling (grey) i think it's a good idea to separate it from the actual content of the page.

gerritbot added a comment.Aug 2 2016, 6:46 PM

Change 302485 had a related patch set uploaded (by Bmansurov):
Wrap revision info and nav in a div for easy formatting in MobileFrontend

https://gerrit.wikimedia.org/r/302485

gerritbot added a comment.Aug 2 2016, 6:50 PM

Change 302486 had a related patch set uploaded (by Bmansurov):
Do not wrap breadcrumbs into a warning box

https://gerrit.wikimedia.org/r/302486

bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 2 2016, 6:51 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 2 2016, 10:54 PM
bmansurov moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 3 2016, 4:59 AM
gerritbot added a comment.Aug 3 2016, 9:17 PM

Change 302485 merged by jenkins-bot:
Wrap revision info and nav in a div for easy formatting in MobileFrontend

https://gerrit.wikimedia.org/r/302485

gerritbot added a comment.Aug 3 2016, 9:29 PM

Change 302486 merged by jenkins-bot:
Do not wrap entire subtitle on diff pages in a warning box

https://gerrit.wikimedia.org/r/302486

Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 3 2016, 9:34 PM
bmansurov removed bmansurov as the assignee of this task.EditedAug 3 2016, 9:43 PM
bmansurov added a subscriber: bmansurov.

To test please visit https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Lang&oldid=329493 and http://reading-web-staging.wmflabs.org/w/index.php?title=Breadcrumbs/2&oldid=31 (notice how the breadcrumbs are outside the warning box).

ReleaseTaggerBot added projects: MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)).Aug 3 2016, 10:00 PM
phuedx assigned this task to dr0ptp4kt.Aug 4 2016, 3:21 AM
dr0ptp4kt added a comment.Aug 6 2016, 12:00 PM

Signing off. I don't have a screenshot from before the first patch was merged, so I can't recall the exact nature of the change. But stable and the provided links look okay and don't seem to be repeating elements.

dr0ptp4kt closed this task as Resolved.Aug 6 2016, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL