Page MenuHomePhabricator
Create Task
Maniphest T139931

Investigate speedup of face detection
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

On profiling article navigation, number one CPU use is face detection. Even though this is on a background thread, it could have user-facing performance implications. This operation should be offloaded to the GPU and set to lower quality of detection to determine if it has a measurable performance improvement.

Event Timeline

JoeWalsh created this task.Jul 11 2016, 12:50 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 11 2016, 12:50 PM
JoeWalsh claimed this task.Jul 13 2016, 12:48 PM
JoeWalsh added a project: iOS-app-v5.1.0-Saturn.
JoeWalsh set the point value for this task to 1.
JoeWalsh moved this task from Backlog to Needs Code Review on the iOS-app-v5.1.0-Saturn board.

https://github.com/wikimedia/wikipedia-ios/pull/772/

Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Jul 14 2016, 10:09 PM
MBinder_WMF added a project: iOS-app-feature-Performance.Jul 25 2016, 7:21 PM
• JMinor moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Jul 25 2016, 7:30 PM
• Fjalapeno triaged this task as Low priority.Jul 26 2016, 3:47 PM
• Fjalapeno moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Jul 28 2016, 7:24 PM
JoeWalsh edited projects, added iOS-app-v5.0.6-Hotfix; removed iOS-app-v5.1.0-Saturn.Aug 2 2016, 1:27 PM
JoeWalsh moved this task from Tasks from Product Backlog to Needs Testing Criteria on the iOS-app-v5.0.6-Hotfix board.
JoeWalsh added a comment.EditedAug 2 2016, 6:26 PM

Testing Criteria:

  1. Visit the "Barack Obama" article on English Wikipedia
  2. Verify that the image at the top of the article shows Barack Obama's face centered in the frame.
  3. Repeat with other articles that contain images of people looking directly at the camera.
JoeWalsh moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.0.6-Hotfix board.Aug 2 2016, 6:27 PM
Nicholas.tsg subscribed.Aug 3 2016, 5:03 PM

I'm testing on iOS 9.3.1 and Wikipedia 5.0.6 (906.1). Tested with articles Barack Obama, Donald Trump, Hillary Clinton, and Bernie Sanders. All of them show faces centered in the frame, so this is fixed.

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.0.6-Hotfix board.Aug 3 2016, 5:03 PM
• JMinor closed this task as Resolved.Aug 11 2016, 6:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL