Page MenuHomePhabricator

"Save for later" action on feed is not accessible
Closed, ResolvedPublic

Description

From Austin:
Under the featured article heading, after reading the summary of the article, VoiceOver announces “Save for Later” as part of the article. The user cannot perform the action. This requires using Accessibility Custom Actions. This may apply to other lists of articles as well.

Event Timeline

JMinor triaged this task as Medium priority.Jul 11 2016, 5:58 PM

This might be fixed already - I can activate "Save for later" using accessibility inspector.

Screen Shot 2016-10-29 at 11.04.04 AM.png (1×2 px, 750 KB)

Is there anything else missing here?

I think I found some of the issues:

Screen Shot 2016-10-29 at 11.41.48 AM.png (758×1 px, 315 KB)

Now it's one accessibility element, that's properly labeled as a button. Should the label say what the button does - e.g. if the value is "saved for later" the label should be "unsave" since that's what activating the button will do?

I updated the label and value. When the article has been saved already - the action is "Unsave" and the value is "Saved". when the article isn't saved, the value is "Not saved" and the action is "Save".

Verified with Austin that this is fixed in 5.3.0 (997)