Page MenuHomePhabricator
Create Task
Maniphest T139993

Add 'seenTime' values for alert/message in the API when fetching list of notifications
Closed, ResolvedPublic
Actions

Description

We can treat it as section-based if notgroupsection is triggered, and combined object if the result is not grouped.

Something like this would be useful:

{
  query: {
    notifications: 
      list: [ ... ],
      seenTime: {
         alert: "2016-07-20T02:47:11Z",
         message: "2016-07-20T02:49:37Z"
      }
    }
}

or if grouped,

{
  query: {
     notifications: {
         alert: {
             list: [ ... ],
             seenTime:  "2016-07-20T02:47:11Z"
         },
         message: {
             list: [ ... ],
             seenTime: "2016-07-20T02:49:37Z"
         }
     }
  }
}

Although in the current code, we're not really using notgroupbysection, but it would be good to support that behavior anyways.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Allow requesting TS_ISO_8601 for ApiEchoMarkSeen, and deprecate TS_MWMattflaschenmediawiki/extensions/Echomaster+27 -2
Add seen time to output of API, in ISO 8601 formatMattflaschenmediawiki/extensions/Echomaster+44 -3
Customize query in gerrit

Related Objects

Event Timeline

Mooeypoo created this task.Jul 11 2016, 6:57 PM
Restricted Application added subscribers: Zppix, • Aklapper. · View Herald TranscriptJul 11 2016, 6:57 PM
• Mattflaschen-WMF claimed this task.Jul 11 2016, 6:59 PM
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 11 2016, 9:06 PM
• Mattflaschen-WMF moved this task from Ready for Pickup to In Development on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 20 2016, 2:56 AM

Two notes:

  1. It will be omitted from the output if it's false, because this is how the API handles false values. If we start using formatversion=2, it will instead explicitly have a false value.
  2. The output format will be ISO per https://www.mediawiki.org/wiki/API:Data_formats#Timestamps .
• Mattflaschen-WMF updated the task description. (Show Details)Jul 20 2016, 2:57 AM
gerritbot subscribed.Jul 20 2016, 3:05 AM

Change 299935 had a related patch set uploaded (by Mattflaschen):
Add seen time to output of API, in ISO 8601 format

https://gerrit.wikimedia.org/r/299935

gerritbot added a project: Patch-For-Review.Jul 20 2016, 3:05 AM
• Mattflaschen-WMF moved this task from In Development to Needs Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 20 2016, 3:06 AM
gerritbot added a comment.Jul 20 2016, 4:31 PM

Change 299935 merged by jenkins-bot:
Add seen time to output of API, in ISO 8601 format

https://gerrit.wikimedia.org/r/299935

Catrope moved this task from Needs Review to QA Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 20 2016, 4:32 PM
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 20 2016, 5:00 PM
gerritbot added a comment.Jul 20 2016, 10:33 PM

Change 300176 had a related patch set uploaded (by Mattflaschen):
Allow requesting TS_ISO_8601 for ApiEchoMarkSeen, and deprecate TS_MW

https://gerrit.wikimedia.org/r/300176

gerritbot added a comment.Jul 21 2016, 2:04 AM

Change 300176 merged by jenkins-bot:
Allow requesting TS_ISO_8601 for ApiEchoMarkSeen, and deprecate TS_MW

https://gerrit.wikimedia.org/r/300176

Etonkovidova subscribed.Jul 22 2016, 12:40 AM

@Mattflaschen-WMF - in betalabs 1.28.0-alpha (46a2d3a), the following warning is displayed when the flyoutis expanded - should it be there?

{warnings: {echomarkseen: {,…}},…}
query
:
{echomarkseen: {result: "success", timestamp: "20160721171957"}}
warnings
:
{echomarkseen: {,…}}
echomarkseen
:
{,…}
*
:
"The MW timestamp output format is deprecated here. In the future, ISO 8601 will always be used for
 the output timestamp format.  Adjust your client and set timestampFormat to 'ISO_8601'."

On Special:Notifications page the same warning is present too.

{warnings: {echomarkseen: {,…}, main: {*: "HTTP used when HTTPS was expected"}},…}
query
:
{echomarkseen: {result: "success", timestamp: "20160722003804"}}
echomarkseen
:
{result: "success", timestamp: "20160722003804"}
result
:
"success"
timestamp
:
"20160722003804"
echomarkseen: {,…}, main: {*: "HTTP used when HTTPS was expected"}}
echomarkseen
:
{,…}
*
:
"The MW timestamp output format is deprecated here. In the future, ISO 8601 will always be used for the output timestamp format.  Adjust your client and set timestampFormat to 'ISO_8601'."
main
• Mattflaschen-WMF added a comment.Jul 22 2016, 1:48 AM
In T139993#2485990, @Etonkovidova wrote:

@Mattflaschen-WMF - in betalabs 1.28.0-alpha (46a2d3a), the following warning is displayed when the flyoutis expanded - should it be there?

Known issue. It's just a warning. @Mooeypoo will make a change to fix it, this is part of our plan.

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-2016-Apr-Jun-Q4 board.Jul 22 2016, 3:25 PM
Mooeypoo mentioned this in T141115: Change "seenTime" format to ISO 8601 in Notifications front-end.Jul 22 2016, 3:59 PM
In T139993#2486050, @Mattflaschen-WMF wrote:
In T139993#2485990, @Etonkovidova wrote:

@Mattflaschen-WMF - in betalabs 1.28.0-alpha (46a2d3a), the following warning is displayed when the flyoutis expanded - should it be there?

Known issue. It's just a warning. @Mooeypoo will make a change to fix it, this is part of our plan.

Opened a followup ticket to adjust the front-end T141115: Change "seenTime" format to ISO 8601 in Notifications front-end

• jmatazzoni closed this task as Resolved.Jul 22 2016, 5:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits