His feed was super sluggish and mostly showing just placeholders.
Video of Toby's phone:
His release was 5.0.4
git checkout "releases/5.0.4.851.1"
The "locationManager:didChangeAuthorizationStatus:" method in WMFLocationManager.m is called repeatedly with the following parameters:
"manager" parameter:
is a different pointer each time
"status" parameter:
is always kCLAuthorizationStatusAuthorizedWhenInUseHis location permissions for the Wikipedia app were set to "while using". Checked under "general > settings > privacy > location services".
Some console output:
The app data: (I was able to build and install 5.0.4 on my phone and run it, then under Devices I was able to replace the container with this one - it actually crashed my phone quickly, whereas on Toby's phone there was not crash, just the looping call to "locationManager:didChangeAuthorizationStatus:")
Potentially related buggy looking code:
- Our "+ (BOOL)isAuthorized" method is checking for kCLAuthorizationStatusAuthorizedWhenInUse twice instead of once for kCLAuthorizationStatusAuthorizedWhenInUse and once for kCLAuthorizationStatusAuthorizedAlways.