| • bmansurov | |
| Jul 12 2016, 5:32 AM |
| F4277843: winphone75-beforesearch.JPG | |
| Jul 15 2016, 5:58 PM |
| F4277846: winphone75-insearch.JPG | |
| Jul 15 2016, 5:58 PM |
| F4277841: opera_mini.jpg | |
| Jul 15 2016, 5:58 PM |
| F4272918: Screen Shot 2016-07-14 at 10.18.54.png | |
| Jul 14 2016, 9:22 AM |
| F4270031: Screen Shot 2016-07-13 at 7.24.58 PM.png | |
| Jul 13 2016, 2:26 PM |
| F4264428: Screen Shot 2016-07-12 at 10.29.40 AM.png | |
| Jul 12 2016, 5:32 AM |
Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page on the above mentioned device, click on the search bar, and type something in the search overlay form. You'll see something like this:
Expected: The clear icon (top right) should be aligned (vertically) in the middle of the search form.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Calculate absolute position of clear button | mediawiki/extensions/MobileFrontend | master | +2 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T138286 "Refreshed" search bar moves up 1px when clicked | |||
| Resolved | dr0ptp4kt | T140051 Search overlay clear icon is misplaced on Nokia Lumia 930 / Windows Phone 8.1 |
@dr0ptp4kt I've removed the devices to test on since this is a regression from T138286 which lists those already.
Change 298871 had a related patch set uploaded (by Jdlrobson):
Calculate absolute position of clear button
Further to my review of 298871: Calculate absolute position of clear button:
Browser: Safari (9.1.1)
OS: 10.11.5
N.B. that I couldn't +2 this even if I wanted to as I don't have access to a Windows Phone 8.1 emulator. Who has a BrowserStack account?
As I noted during my review of the change, I tested it in the following browsers:
It's unclear to me if it's this patch or if it's another patch, but en.m.wikipedia.beta.wmflabs.org now has a couple of oddities.
I'm marking this task as resolved given @phuedx's testing on the Lumia (and my verification in Safari for iOS 9 phone plus Chrome for Android 5 phone and tablet), but here they are for reference:
In Opera Mini, prior to entering the search bar at all, the magnifying glass is now appearing (good), but it's mashed into the placeholder text (similar to how the search results page was showing up).
On Windows Phone 7.5 IE, the magnifying glass is now appearing (good), but it's squished. That's both prior to search and while in the midst of searching.
I created T140487 as it came up on another patchset review. Can you confirm that Windows 7 phone runs IE9?
According to a website that reflects the UA, that phone runs IEMobile/9.0, yes. I also created T140504: Windows Phone 7.5 Search UX Issues and T140490: Search magnifying glass and placeholder text mashed together in Opera Mini extreme mode (all resolutions).
@MBinder_WMF this was a regression based on the planned sprint work of the pointed T138286 thus it shouldn't be pointed.
