Page MenuHomePhabricator

Editing a gallery sets the widths and heights attributes to 'px' if left empty
Closed, ResolvedPublic1 Story Points

Description

If these attributes are left empty in the form they should be omitted in the wikitext (i.e. set to undefined in mwData)

Event Timeline

Esanders created this task.Jul 12 2016, 1:51 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 12 2016, 1:51 PM
Esanders triaged this task as High priority.Jul 12 2016, 1:52 PM
Esanders moved this task from To Triage to Blocked on the VisualEditor board.

Change 298629 had a related patch set uploaded (by Tchanders):
Fix Gallery Dialog dimensions editing

https://gerrit.wikimedia.org/r/298629

Change 298629 merged by jenkins-bot:
MWGalleryDialog: Don't set blank values for width, height

https://gerrit.wikimedia.org/r/298629

Jdforrester-WMF closed this task as Resolved.Jul 12 2016, 11:16 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.