Page MenuHomePhabricator
Create Task
Maniphest T140094

Editing a gallery sets the widths and heights attributes to 'px' if left empty
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

If these attributes are left empty in the form they should be omitted in the wikitext (i.e. set to undefined in mwData)

pasted_file (353×904 px, 34 KB)

Details

SubjectRepoBranchLines +/-
MWGalleryDialog: Don't set blank values for width, heightmediawiki/extensions/VisualEditormaster+2 -2
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 12 2016, 1:51 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 12 2016, 1:51 PM
Esanders triaged this task as High priority.Jul 12 2016, 1:52 PM
Esanders moved this task from To Triage to Blocked on the VisualEditor board.
Esanders added projects: MediaWiki-Gallery, VisualEditor-MediaWiki.
gerritbot subscribed.Jul 12 2016, 9:09 PM

Change 298629 had a related patch set uploaded (by Tchanders):
Fix Gallery Dialog dimensions editing

https://gerrit.wikimedia.org/r/298629

gerritbot added a project: Patch-For-Review.Jul 12 2016, 9:09 PM
gerritbot added a comment.Jul 12 2016, 10:32 PM

Change 298629 merged by jenkins-bot:
MWGalleryDialog: Don't set blank values for width, height

https://gerrit.wikimedia.org/r/298629

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 12 2016, 11:00 PM
Jdforrester-WMF closed this task as Resolved.Jul 12 2016, 11:16 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set the point value for this task to 1.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL