Page MenuHomePhabricator

Test EditPage to make sure it can handle CollaborationHub edit conflicts
Closed, ResolvedPublic

Description

SpecialEditCollaborationHub needs to actually print out the errors, messages, etc that a normal edit page would (editconflict (T131474), loss of sessiondata, expired tokens, etc).

Current behaviour when something goes wrong is to just go back to itself and not give any explanation what happened.

Event Timeline

Harej renamed this task from Support for dumping out the usual messages, errors, etc in specialeditcollaborationhub to Test EditPage to make sure it can handle CollaborationHub edit conflicts.Jul 22 2016, 3:35 PM
Harej assigned this task to Bawolff.
Harej triaged this task as High priority.Jul 22 2016, 4:13 PM

Tested for the traditional edit conflict and it seems to work just fine.

Screen Shot 2016-10-02 at 3.17.27 AM.png (293×1 px, 38 KB)

Deleted my session cookie in the middle of an edit and it was handled gracefully.

Screen Shot 2016-10-02 at 3.20.36 AM.png (250×1 px, 55 KB)

Set the session expiration date to March 31, 2000 and once again, the edit failed gracefully.

@Bawolff, any other testing we need to do?