Page MenuHomePhabricator
Create Task
Maniphest T140237

Toolbar dialogs (Special Character, Find & Replace) overlap floating toolbar menus when toolbar is floating
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When VE's toolbar is in floating mode on scroll, open Special Character dialog is overlapping Article Target toolbar' dialogs.
Tested in latest Chrome/Firefox on MacOS.

Screenshot:

T140237-VisualEditor-floating-toolbar-overlapped-by-SpecialCharacterDialog.png (668×299 px, 29 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix `z-index` issue on floating toolbar dialogVolkerEmediawiki/extensions/VisualEditormaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Jul 13 2016, 1:12 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 13 2016, 1:12 PM
Volker_E updated the task description. (Show Details)Jul 13 2016, 1:54 PM
gerritbot subscribed.Jul 13 2016, 2:16 PM

Change 298736 had a related patch set uploaded (by VolkerE):
Fix z-index issue on floating toolbar dialog

https://gerrit.wikimedia.org/r/298736

gerritbot added a project: Patch-For-Review.Jul 13 2016, 2:16 PM
Jdforrester-WMF renamed this task from VisualEditor: Special Character dialog is overlapping/mixing into floating Article Target toolbar' dialogs to Toolbar dialogs (Special Character, Find & Replace) overlap floating toolbar menus when toolbar is floating.Jul 15 2016, 5:22 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor-EditingTools.

Yup. Doesn't occur in stand-alone mode.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jul 15 2016, 5:22 PM
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF merged a task: T141409: Edit notices popup should not be layered between parts of Find/Replace toolbar .Jul 29 2016, 11:24 PM
Jdforrester-WMF added a subscriber: Krinkle.
gerritbot added a comment.Aug 1 2016, 4:42 PM

Change 298736 merged by jenkins-bot:
Fix z-index issue on floating toolbar dialog

https://gerrit.wikimedia.org/r/298736

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Aug 1 2016, 5:00 PM
Jdforrester-WMF closed this task as Resolved.Aug 9 2016, 7:33 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF mentioned this in T128523: Find/replace dialog in VE overlaps edit notice warning (? in Safari).Aug 25 2016, 4:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits