Modernize the admin tool's codebase
Closed, ResolvedPublic
Actions

Description

The admin tool (https://tools.wmflabs.org) is the front page for Tool Labs. The codebase that powers this PHP site is a one-off "framework" that has been around for quite a while (3+ years?). Some work was done in early 2016 to update the codebase and make it slightly easier to work with, but there is a lot more that could and should be done to make this a codebase that people are not afraid to work with.

I'd like to update it to use the rWSLI wikimedia/slimapp framework as a base. This will allow introducing more structure to the code as well as open up the possibility of internationalization and other improvements.

Details

Project	Branch	Lines +/-	Subject
labs/toollabs	master	+0 -33 K	Remove legacy www content
operations/puppet	production	+0 -27	wmcs: remove toollabs::admin_web_updater
mediawiki/vagrant	master	+93 -0	[DO NOT MERGE] role::tooladmin

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	bd808	T140254 Modernize the admin tool's codebase
Resolved	bd808	T140251 Split OGE grid status data collection out of admin tool
Duplicate	None	T140255 Add kubernetes status page to admin tool

Event Timeline

bd808 created this task.Jul 13 2016, 3:52 PM

Restricted Application added subscribers: Zppix, • Aklapper. · View Herald TranscriptJul 13 2016, 3:52 PM

bd808 added projects: Toolforge, Community-Tech-Tool-Labs.Jul 13 2016, 3:53 PM

Restricted Application added a project: Cloud-Services. · View Herald TranscriptJul 13 2016, 3:53 PM

bd808 added a subtask: T140251: Split OGE grid status data collection out of admin tool.Jul 13 2016, 3:53 PM

bd808 created subtask T140255: Add kubernetes status page to admin tool.Jul 13 2016, 3:56 PM

bd808 claimed this task.Jul 14 2016, 3:03 PM

Restricted Application added a project: User-bd808. · View Herald TranscriptJul 14 2016, 3:03 PM

bd808 moved this task from Backlog to Doing on the Community-Tech-Tool-Labs board.Jul 14 2016, 3:03 PM

Working on this as the https://tools.wmflabs.org/admin-beta/ tool with source code at R1922 tool-admin-web.

bd808 moved this task from To Do to In Dev/Progress on the User-bd808 board.Jul 14 2016, 3:08 PM

@yuvipanda and @valhallasw I think that this is ready to actually use in place of the current admin tool's www content. Could the two of you give both the live app and the code a look to see if you can spot any obvious problems?

Change 299703 had a related patch set uploaded (by BryanDavis):
iDO NOT MERGE] role::tooladmin

https://gerrit.wikimedia.org/r/299703

gerritbot added a project: Patch-For-Review.Jul 19 2016, 2:27 AM

bd808 moved this task from In Dev/Progress to Needs Review/Feedback on the User-bd808 board.Jul 19 2016, 2:44 AM

I like it! (and @valhallasw is on vacation for another week I think)

I tried to deploy this live to https://tools.wmflabs.org/ and hit some problems:

https://tools.wmflabs.org/admin/tools returned an empty page,
404/503 handling for tools returned empty pages (e.g. https://tools.wmflabs.org/ninihil/?page_id=285988).
Starting the tool on k8s did not seem to work.

There was no output to error.log for any of these problems. All of these actions seem to work at https://tools.wmflabs.org/admin-beta/, but live debugging as the main https://tools.wmflabs.org/ landing page is a bit nerve-wracking.

@yuvipanda can you think of some way I can test in a more production like environement than my local mediawiki-vagrant setup without actually making the tool live for the whole world?

Here's how I was testing switching back and forth between the new code and the legacy code:

Switch tool-admin-web on as k8s service

webservice stop; rm public_html; ln -s tool-admin-web/public public_html; cp .lighttpd.conf.new .lighttpd.conf; webservice --backend kubernetes start

Switch tool-admin-web on as OGE service

webservice stop; rm public_html; ln -s tool-admin-web/public public_html; cp .lighttpd.conf.new .lighttpd.conf; webservice --backend gridengine start

Switch back to legacy OGE service

webservice stop; rm public_html; ln -s toollabs/www public_html; cp .lighttpd.conf.old .lighttpd.conf; webservice --backend gridengine start

bd808 triaged this task as Medium priority.Jul 19 2016, 11:39 PM

bd808 closed subtask T140251: Split OGE grid status data collection out of admin tool as Resolved.

bd808 moved this task from Needs Review/Feedback to Done on the User-bd808 board.Aug 29 2016, 6:38 PM

bd808 moved this task from Done to Needs Review/Feedback on the User-bd808 board.

bd808 changed the task status from Open to Stalled.Sep 20 2016, 4:17 PM

bd808 moved this task from Triage to In Progress on the Cloud-Services board.Nov 24 2016, 9:42 PM

scfc moved this task from Triage to Waiting for code review on the Toolforge board.Nov 27 2016, 12:22 AM

Note to my future self:

[22:35]  <yuvipanda>	bd808: the way to test these would be to test this on tools-proxy-02 by hand hacking
[22:35]  <yuvipanda>	that way it won't be live for people
[22:35]  <yuvipanda>	and you can curl
[22:35]  <    bd808>	oh nice
[22:36]  <    bd808>	just pointing proxy-02 at admin-beta instead of admin then?
[22:37]  <yuvipanda>	bd808: yeah

Change 299703 abandoned by BryanDavis:
[DO NOT MERGE] role::tooladmin

https://gerrit.wikimedia.org/r/299703

bd808 edited projects, added cloud-services-team (Kanban); removed Patch-For-Review, Community-Tech-Tool-Labs.May 19 2017, 1:35 PM

bd808 moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.May 19 2017, 1:38 PM

See T166295: tools.wmflabs.org needs a documentation update for some content updates that will be needed.

• Phabricator_maintenance removed a subscriber: yuvipanda.Jun 7 2017, 6:41 PM

Mentioned in SAL (#wikimedia-cloud) [2017-07-27T22:27:07Z] <bd808> tool-admin-web is live. Switch back with ~/old.sh if things go sideways. (T140254)

It's alive! I'm going to leave this open for a couple of days in case the prior broken behavior resurfaces.

Change 368318 had a related patch set uploaded (by BryanDavis; owner: Bryan Davis):
[operations/puppet@production] wmcs: remove toollabs::admin_web_updater

https://gerrit.wikimedia.org/r/368318