Maniphest T140400

Fix iOS 8 article link tap regression
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Jul 14 2016, 7:01 PM

Tags

Referenced Files

None

Subscribers

Description

The WKScriptMessage refactor (mine) broke iOS 8 links.

Related Objects

Mentioned In: rAPIOS3c4b3acab09f: Merge pull request #776 from wikimedia/regression/iOS8-link-clicks/T140400
rAPIOS20d807ee81b9: Merge branch 'develop' into regression/iOS8-link-clicks/T140400

Event Timeline

Mhurd created this task.Jul 14 2016, 7:01 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 14 2016, 7:01 PM

Mhurd added a project: Wikipedia-iOS-App-Backlog.Jul 14 2016, 7:01 PM

https://github.com/wikimedia/wikipedia-ios/pull/776

Repro steps:

load app in either iOS 8 simulator or an iOS 8 device
load any article
try to tap a link
if tapping the link causes that link's page to load, we've fixed the issue

Diffusion mentioned this in rAPIOS20d807ee81b9: Merge branch 'develop' into regression/iOS8-link-clicks/T140400.Jul 14 2016, 8:35 PM

• Fjalapeno mentioned this in rAPIOS3c4b3acab09f: Merge pull request #776 from wikimedia/regression/iOS8-link-clicks/T140400.Jul 14 2016, 9:38 PM

Mhurd moved this task from Doing to Needs QA on the iOS-app-v5.1.0-Saturn board.Jul 14 2016, 10:06 PM

Danny_B added a project: Regression.Jul 16 2016, 12:12 AM

• Fjalapeno moved this task from Needs QA to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Jul 19 2016, 2:29 AM

• Fjalapeno triaged this task as High priority.Jul 25 2016, 5:34 PM

• Fjalapeno moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.

MBinder_WMF added a project: iOS-app-Bugs.Jul 25 2016, 7:14 PM

• Fjalapeno moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Jul 28 2016, 7:23 PM

https://github.com/wikimedia/wikipedia-ios/pull/769

JoeWalsh edited projects, added iOS-app-v5.0.6-Hotfix; removed iOS-app-v5.1.0-Saturn.Aug 2 2016, 6:25 PM

JoeWalsh moved this task from Tasks from Product Backlog to Ready for PM Signoff on the iOS-app-v5.0.6-Hotfix board.

• JMinor closed this task as Resolved.Aug 11 2016, 6:32 PM