Page MenuHomePhabricator
Create Task
Maniphest T140419

Deploy a PHP and HHVM patch (Exif values retrieved incorrectly if they appear before IFD)
Closed, ResolvedPublic
Actions

Description

Is it possible to deploy a PHP and HHVM patch to fix T97253: Exif values retrieved incorrectly if they appear before IFD? Patches exist (and are needed) for both of them. The patch changes three lines of code (plus tests, release notes, etc.).

The patches are:

I have verified that they apply cleanly to PHP 5.5.9 and HHVM 3.12.1, which appear to be what we're running.

Related Objects
Search...

Event Timeline

matmarex created this task.Jul 14 2016, 8:58 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 14 2016, 8:58 PM
matmarex mentioned this in T140446: Consider our options for fixing existing files affected by T97253.Jul 15 2016, 2:31 AM
matmarex added a parent task: T32961: Run refreshImageMetadata.php --force.Jul 16 2016, 9:35 PM
matmarex removed a parent task: T97253: Exif values retrieved incorrectly if they appear before IFD.Jul 16 2016, 9:41 PM
matmarex added a subtask: T97253: Exif values retrieved incorrectly if they appear before IFD.
matmarex added projects: Multimedia, Commons.Jul 17 2016, 9:35 PM
Restricted Application added subscribers: Poyekhali, Steinsplitter, Matanya. · View Herald TranscriptJul 17 2016, 9:35 PM
matmarex moved this task from Untriaged to Doing on the Multimedia board.Jul 17 2016, 9:57 PM
matmarex mentioned this in T97253: Exif values retrieved incorrectly if they appear before IFD.Jul 17 2016, 10:01 PM
matmarex closed subtask T97253: Exif values retrieved incorrectly if they appear before IFD as Resolved.
Raymond subscribed.Jul 18 2016, 5:52 AM
matmarex added a comment.Jul 22 2016, 4:58 PM

Could this be triaged or declined, please? I would like to know if this is possible to do at all, or if we have to just wait a couple years until we upgrade to PHP/HHVM that has these patches.

ori added subscribers: Joe, ori.Jul 22 2016, 5:09 PM

It's definitely possible; we do this with security patches and other critical updates. @Joe, what do you think?

matmarex raised the priority of this task from Medium to Needs Triage.Aug 4 2016, 7:29 PM
matmarex added a comment.Aug 22 2016, 9:53 PM

Any update, please?

MoritzMuehlenhoff claimed this task.Sep 6 2016, 1:06 PM
MoritzMuehlenhoff subscribed.

Sure, we can merge that patch the next time we upgrade to a HHVM security release. HHVM upgrades are fairly time-consuming so we can't do that for this patch alone, but piggybacking it into the next security release is no problem.

There's no time frame for the next HHVM security release yet, but usually up to 1-2 months at most.

We're currently no longer using PHP on production app servers, is that relevant for PHP/CI? These use unpatched PHP builds at the moment.

matmarex added a comment.Sep 6 2016, 3:55 PM

Thank you for the reply!

We're currently no longer using PHP on production app servers, is that relevant for PHP/CI? These use unpatched PHP builds at the moment.

Ah, alright then. I was under the impression that we still have imagescalers or jobrunners or something running on PHP rather than HHVM.

Ghouston mentioned this in T145953: File displaying invalid metadata in Commons, when the original Exif seems fine..Sep 18 2016, 4:53 AM
Aklapper added a parent task: T145953: File displaying invalid metadata in Commons, when the original Exif seems fine..Sep 18 2016, 6:49 PM
matmarex merged a task: T145953: File displaying invalid metadata in Commons, when the original Exif seems fine..Sep 19 2016, 5:32 PM
matmarex added a subscriber: Ghouston.
MoritzMuehlenhoff closed this task as Resolved.Oct 7 2016, 7:52 AM

@matmarex : I'm currently preparing the next HHVM update, but when having a closer look at the your patch I noticed it's already live on the production cluster: When it was merged, the HHVM developers backported it into the 3.12.8 release, which we're currently using on the production cluster since mid-August.

matmarex added a comment.Oct 7 2016, 2:44 PM

Nice surprise. Thanks!

MoritzMuehlenhoff added a comment.Oct 25 2016, 8:38 PM

The patch is present in the 3.12.7+dfsg-1+wmf1 package onwards and this is version installed on all hosts with hhvm in production.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits