Page MenuHomePhabricator

Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries
Open, MediumPublic40 Estimated Story Points

Description

Having "show changes" take you to a different page in the save dialog is unnecessary. Often I will want to preview the changes in order to write my edit summary, but I'm unable to view the two side-by-side.

If we can implement T105173 (HTML diffs), we can show those instantly with an option to switch to wikitext diff.

Event Timeline

Esanders created this task.Jul 15 2016, 9:46 AM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 15 2016, 9:46 AM
Jdforrester-WMF triaged this task as Medium priority.Jul 19 2016, 7:02 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF added a project: Design.
Jdforrester-WMF set the point value for this task to 40.
Jdforrester-WMF renamed this task from Redesign save dialog / diff view to Redesign submit dialog / diff view to show changes alongside the edit summary, to help prompt people to write better summaries.Feb 28 2018, 9:41 PM

Well, we have visual diffs now...

Esanders renamed this task from Redesign submit dialog / diff view to show changes alongside the edit summary, to help prompt people to write better summaries to Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries.Apr 25 2019, 8:39 PM

Something along these lines:

Potential issues:

  • Putting the legal message below the diff could push it out of view.
  • Wikis can configure the legal message to be much longer (or shorter) than the one shown here, for example on de.wiki:
    Putting this message above the diff could push the diff out of view
  • On some diffs (usually table diffs) the visual diff can timeout and fail, we therefore may not want to run the visual diff automatically.

Potential solutions:

  • Putting the diff behind a "click to reveal" button could solve both of the above issues (performance and legal-below-fold)
  • MobileFrontend uses a simplified legal message which is designed to be much shorter. Using this on desktop could free up some space.

Example diffs for consideration when designing:

Short visual diff, vertical ellipsis will show unless the diff is adjacent to the start/end of doc:


Equivalent wikitext diff

Visual diff with attribute changes:

In both modes there is no limit to the diff length, so the user may have to scroll through pages of changes.

Change 533199 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] WIP Move diff to edit summary page

https://gerrit.wikimedia.org/r/533199

JTannerWMF added a subscriber: JTannerWMF.

Looks like this is being worked on.

@Esanders it looks like you and @iamjessklein is working on this together?

Esanders added a comment.EditedAug 29 2019, 3:25 PM

I've deployed an undesigned prototype to the secondary prototype server: https://visualeditor-test.wmflabs.org/wiki/Pride_and_Prejudice?veaction=edit so we can see how this feels. (Requires login, ping me if you don't have the password)

Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 5 2020, 12:05 AM

We aren't focused on this work right now, @Esanders if you think this judgement call is wrong the put it in needs prioritization so we can discuss it in a future meeting.

JTannerWMF moved this task from Incoming to Freezer on the Editing-team board.Feb 19 2020, 10:30 PM
JTannerWMF removed a project: Editing Design.
This comment was removed by Esanders.
Esanders removed a subscriber: matmarex.Mar 2 2020, 3:45 PM

Test wiki created on Patch Demo by ESanders (WMF) using patch(es) linked to this task:

http://patchdemo.wmflabs.org/wikis/760d0aca2d743bb87426b5be2a3d15c7/w/