| Esanders | |
| Jul 15 2016, 9:46 AM |
| F30142995: image.png | |
| Aug 28 2019, 4:54 PM |
| F30142992: image.png | |
| Aug 28 2019, 4:54 PM |
| F30143003: image.png | |
| Aug 28 2019, 4:54 PM |
| F30142842: image.png | |
| Aug 28 2019, 3:37 PM |
| F28776015: image.png | |
| Apr 25 2019, 8:52 PM |
Having "show changes" take you to a different page in the save dialog is unnecessary. Often I will want to preview the changes in order to write my edit summary, but I'm unable to view the two side-by-side.
If we can implement T105173 (HTML diffs), we can show those instantly with an option to switch to wikitext diff.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/VisualEditor | master | +101 -82 | WIP Move diff to edit summary page |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T143341 When re-starting a local draft, show the user a diff so they know what they're getting into | |||
| Open | None | T140451 Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries |
Potential issues:
Potential solutions:
Example diffs for consideration when designing:
Short visual diff, vertical ellipsis will show unless the diff is adjacent to the start/end of doc:
Visual diff with attribute changes:
In both modes there is no limit to the diff length, so the user may have to scroll through pages of changes.
Change 533199 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] WIP Move diff to edit summary page
I've deployed an undesigned prototype to the secondary prototype server: https://visualeditor-test.wmflabs.org/wiki/Pride_and_Prejudice?veaction=edit so we can see how this feels. (Requires login, ping me if you don't have the password)
We aren't focused on this work right now, @Esanders if you think this judgement call is wrong the put it in needs prioritization so we can discuss it in a future meeting.
Test wiki created on Patch Demo by ESanders (WMF) using patch(es) linked to this task:
http://patchdemo.wmflabs.org/wikis/760d0aca2d743bb87426b5be2a3d15c7/w/
@Esanders: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!
