| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Disable $wgAbuseFilterProfile for commonswiki | operations/mediawiki-config | master | +0 -2 |
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T128543 Hunt down duplicate memcached gets | |||
| Resolved | PRODUCTION ERROR | None | T140518 Duplicate get(): "commonswiki:abusefilter:profile:…:…" fetched 2 times | ||
| Resolved | matmarex | T140522 All abuse filters run twice for every file upload | |||
| Resolved | matmarex | T140521 The UploadVerifyFile hook should say whether the upload is going to be immediately published, so consumers of UploadVerifyUpload hook can skip duplicate checks |
Event Timeline
Comment Actions
This happens 166 times for every file upload on Commons (58 active filters, 3 keys per each). 3433402 hits in last 24 hours.
Comment Actions
Long-term fix for this is T140522. Short-term, if you want to silence the logs, set $wgAbuseFilterProfile=false for Commons (it should already by false for other wikis).
Comment Actions
On 1.28.0-wmf.10 the top offenders over an hour are from commonswiki:
commonswiki:abusefilter:stats:total:default (1365) commonswiki:abusefilter:profile:4:total (1363) commonswiki:abusefilter:profile:4:count (1362) commonswiki:abusefilter:profile:4:conds (1362) commonswiki:abusefilter:profile:31:total (1362) commonswiki:abusefilter:profile:16:total (1362) commonswiki:abusefilter:profile:14:count (1362) commonswiki:abusefilter:profile:12:count (1362) commonswiki:abusefilter:profile:8:total (1361) commonswiki:abusefilter:profile:8:count (1361) commonswiki:abusefilter:profile:8:conds (1361 ...
Over an hour commonswiki had 236k hits out of 240k total.
Comment Actions
Change 283243 had a related patch set uploaded (by Bartosz Dziewoński):
Disable $wgAbuseFilterProfile for commonswiki
Comment Actions
As T140522 was fixed, it should be okay to revert https://gerrit.wikimedia.org/r/283243. I don't think anybody is missing the profiling data right now, so I won't be doing it now, just noting that if it is requested, there are no blockers anymore.