Page MenuHomePhabricator

All abuse filters run twice for every file upload
Closed, ResolvedPublic

Description

All abuse filters run twice for every file upload. This was introduced recently by me in 069e0c89a5e73cdb05f8d1f79e520ef560e9c30b (https://gerrit.wikimedia.org/r/#/c/295254/), accruing some tech debt to implement a long-requested feature, which allows Commons community to reduce the workload of file patrollers.

This is probably not a big deal in practice, because file uploads don't happen as often as edits, and because they're already slow. But there are some problems:

Event Timeline

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 15 2016, 10:51 PM
Danny_B updated the task description. (Show Details)Jul 16 2016, 2:13 AM
matmarex claimed this task.Jul 18 2016, 8:12 PM
matmarex triaged this task as High priority.
Gunnex added a subscriber: Gunnex.Jul 26 2016, 10:02 AM

Change 300843 merged by jenkins-bot:
Only run filters once for direct uploads (without stash)

https://gerrit.wikimedia.org/r/300843