Page MenuHomePhabricator
Create Task
Maniphest T140595

Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode
Closed, ResolvedPublic
Actions

Description

Feedback from there: opening Mediaviewer when you click on a thumbnail is not intuitive. You expect to display that item on the slideshow instead of having it big.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
GallerySlideshow: Fire 'wikipage.content' hook when the main image changesmediawiki/coremaster+2 -1
bootstrap: isAllowedThumb: Don't allow slideshow gallery thumbnailsmediawiki/extensions/MultimediaViewermaster+8 -5
GallerySlideshow: Don't open MultimediaViewer when a thumbnail is clickedmediawiki/coremaster+5 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Trizek-WMF created this task.Jul 18 2016, 8:24 AM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 18 2016, 8:24 AM
Restricted Application added subscribers: Zppix, Matanya. · View Herald Transcript
Trizek-WMF removed projects: User-notice, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), Design.Jul 18 2016, 8:24 AM
Ahm_masum subscribed.Nov 17 2016, 1:15 PM
MarkTraceur triaged this task as Medium priority.Dec 2 2016, 9:18 PM
MarkTraceur moved this task from Untriaged to Triaged on the Multimedia board.
• Prtksxna claimed this task.Jan 16 2017, 10:02 AM
gerritbot subscribed.Jan 16 2017, 10:05 AM

Change 332220 had a related patch set uploaded (by Prtksxna):
GallerySlideshow: Don't open MultimediaViewer when a thumbnail is clicked

https://gerrit.wikimedia.org/r/332220

gerritbot added a project: Patch-For-Review.Jan 16 2017, 10:05 AM
• Prtksxna added a comment.Jan 16 2017, 10:11 AM

If we do this should we open MultimediaViewer when the current image on the slideshow is clicked?

• Prtksxna added a project: MediaViewer.Jan 18 2017, 8:55 AM
gerritbot added a comment.Jan 18 2017, 8:55 AM

Change 332745 had a related patch set uploaded (by Prtksxna):
bootstrap: isAllowedThumb: Don't allow slideshow gallery thumbnails

https://gerrit.wikimedia.org/r/332745

gerritbot added a comment.Jan 18 2017, 8:56 AM

Change 332220 abandoned by Prtksxna:
GallerySlideshow: Don't open MultimediaViewer when a thumbnail is clicked

Reason:

:-( Stuff in core shouldn't know anything about extensions. Is there a way to fix this inside MediaViewer instead?

Yes! And its cleaner Ia0e230c7649c399d0a43acacf55ff72db9bc0e8e.

https://gerrit.wikimedia.org/r/332220

matmarex subscribed.Jan 18 2017, 10:23 AM

The big thumbnail should probably open MediaViewer though?

pasted_file (944×1 px, 526 KB)

• Prtksxna added a comment.Jan 18 2017, 10:26 AM
In T140595#2948831, @matmarex wrote:

The big thumbnail should probably open MediaViewer though?

That is what I was thinking too.

phuedx added a project: Web-Team-Backlog-Archived.Jan 18 2017, 11:26 PM
phuedx moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog-Archived board.
gerritbot added a comment.Jan 19 2017, 9:19 AM

Change 332973 had a related patch set uploaded (by Prtksxna):
GallerySlideshow: Fire 'wikipage.content' hook when the main image changes

https://gerrit.wikimedia.org/r/332973

gerritbot added a comment.Jan 19 2017, 10:20 AM

Change 332745 merged by jenkins-bot:
bootstrap: isAllowedThumb: Don't allow slideshow gallery thumbnails

https://gerrit.wikimedia.org/r/332745

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)).Jan 19 2017, 11:00 AM
matmarex renamed this task from Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode to Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode; instead, we should do it for the big image.Jan 20 2017, 9:31 PM
matmarex updated the task description. (Show Details)
Jdlrobson removed a project: Patch-For-Review.Jan 23 2017, 5:34 PM
• Prtksxna added a comment.Jan 24 2017, 4:13 AM

https://gerrit.wikimedia.org/r/332973 is currently the Patch-For-Review

• Prtksxna added a project: Patch-For-Review.Jan 24 2017, 4:13 AM
• Prtksxna renamed this task from Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode; instead, we should do it for the big image to Consider not to open MediaViewer when a user clicks on a thumbnail on the rotating reader-interactive "slider" gallery mode.Jan 24 2017, 5:49 AM
• Prtksxna closed this task as Resolved.
• Prtksxna removed a project: Patch-For-Review.
• Prtksxna updated the task description. (Show Details)
• Prtksxna mentioned this in T156102: Open Multimediaviewer for the big image in a GallerySlideshow.
gerritbot added a comment.Jan 24 2017, 5:55 AM

Change 332973 abandoned by Prtksxna:
GallerySlideshow: Fire 'wikipage.content' hook when the main image changes

Reason:
See T156102 and T156103

https://gerrit.wikimedia.org/r/332973

• Phabricator_maintenance moved this task from 2014-15 Q4 to 2016-17 Q3 on the Web-Team-Backlog-Archived board.Mar 6 2018, 11:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits