Page MenuHomePhabricator

Remove deprecated wikibase config variables from configurations
Closed, ResolvedPublic1 Estimated Story Points

Description

From: https://phabricator.wikimedia.org/T138788#2463523

The result of this is any site using the sole config variable $wgMFUseWikibaseDescription = true from before June 27th to show taglines who upgrades will now lose their tagline unless they turn on $wgMFDisplayWikibaseDescriptions immediately.

Find where $wgMFUseWikibaseDescription is still used and add the new config $wgMFDisplayWikibaseDescriptions = [ 'tagline' => true ].

Remove the old variables after the changes in T138788 roll out (21st of July).

AC

  • Wikis with old configuration variables and wikibase descriptions enabled keep the descriptions enabled as the config changes/deprecations take effect in rollout
  • Old configuration variables are removed and configuration is up to date and lean
  • The fallback deprecated config variables should remain in MobileFrontend to allow time for 3rd parties to catch up

Event Timeline

@dr0ptp4kt I've pulled this in as it is a followup from last sprint 76 and sensitive to the train schedule.

Needs priority and estimation.

Change 299615 had a related patch set uploaded (by Jdlrobson):
Wikidata description config cleanup

https://gerrit.wikimedia.org/r/299615

Have prepared patch. Would appreciate review prior to Thursday.

Change 299615 merged by jenkins-bot:
Wikidata description config cleanup

https://gerrit.wikimedia.org/r/299615

Done but amongst all this Wikidata description testing I found we've caused another minor regression.. T141067

^ Looks like cookie licking to me…

What seems to be the problem, officer @phuedx? I've checked the mediawiki-config repo for old config variables and didn't find any.

@bmansurov: You're now fully responsible for signing off this task! Congratulations!

@dr0ptp4kt Can you clarify if you needed one dev to signoff on this, or all 4 that were @-mentioned?