Maniphest T140652

Drop old "jshint" job from MediaViewer extension test/etc. pipelines
Closed, ResolvedPublic
Actions

Description

It's blocking using it via npm – see https://gerrit.wikimedia.org/r/#/c/299537/.

(Should it be removed generally?)

Details

	Subject	Repo	Branch	Lines +/-
	MediaViewer: Drop old jsduck/jshint templates, add composer	integration/config	master	+1 -2

Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Jul 18 2016, 3:54 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 18 2016, 3:54 PM

• jhobs added a project: Web-Team-Backlog.Jul 18 2016, 5:12 PM

Why not fix errors?

• jhobs triaged this task as Low priority.Jul 18 2016, 5:14 PM

• jhobs moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

In T140652#2471632, @bmansurov wrote:

Why not fix errors?

They aren't errors, they're version mis-matches.

Change 299771 had a related patch set uploaded (by Jforrester):
MediaViewer: Drop old jsduck/jshint templates, add composer

https://gerrit.wikimedia.org/r/299771

gerritbot added a project: Patch-For-Review.Jul 19 2016, 3:51 PM

jshint is some 2+ years old version that is snapshotted on the slaves. And indeed that should be replaced by a npm test with proper dependencies.

Same for jsduck which is provided by a .deb package. Can/should be moved to bundler / rake

Change 299771 merged by jenkins-bot:
MediaViewer: Drop old jsduck/jshint templates, add composer

https://gerrit.wikimedia.org/r/299771

Jdlrobson added projects: Reading-Web-Sprint-77-Segmentation-fault, Unplanned-Sprint-Work.Jul 19 2016, 8:38 PM

Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-77-Segmentation-fault board.

Jdforrester-WMF closed this task as Resolved.Jul 19 2016, 8:43 PM

Jdforrester-WMF claimed this task.

MBinder_WMF moved this task from Triaged but Future to 2016-17 Q1 on the Web-Team-Backlog board.Oct 10 2017, 7:42 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptOct 10 2017, 7:43 PM