Page MenuHomePhabricator

Make Notification page on mobile usable by suppressing the left, filtering nav (for now)
Closed, ResolvedPublic

Assigned To
Authored By
Jul 18 2016, 8:45 PM
Referenced Files
F4312968: IMG_1168.PNG
Jul 27 2016, 8:19 PM
F4312985: IMG_1169.PNG
Jul 27 2016, 8:19 PM
F4312959: IMG_1167.PNG
Jul 27 2016, 8:19 PM
F4312799: IMG_1555.PNG
Jul 27 2016, 6:53 PM
F4312801: IMG_1554.PNG
Jul 27 2016, 6:53 PM
F4299065: Screen Shot 2016-07-22 at 5.06.17 PM.png
Jul 23 2016, 12:18 AM
F4299056: IMG_1542.PNG
Jul 23 2016, 12:18 AM
F4299054: IMG_1543 (2).PNG
Jul 23 2016, 12:18 AM
"Like" token, awarded by RandomDSdevel.


To make the notifications page usable on mobile, we will (at first) supporess the left nav. (A plan for making the nav mobile friendly is described in a separate ticket, T139525.)

Event Timeline

jmatazzoni renamed this task from Make mobile-friendly version of the Notifications page left nav to Make Notification page on mobile usable by suppressing the left, filtering nav (for now).Jul 18 2016, 8:51 PM
jmatazzoni assigned this task to Mooeypoo.
jmatazzoni updated the task description. (Show Details)
jmatazzoni added subscribers: Mooeypoo, Pginer-WMF.
Catrope triaged this task as High priority.Jul 18 2016, 9:57 PM

Change 299868 had a related patch set uploaded (by Mooeypoo):
[wip] Make Special:Notifications responsive

Change 299868 merged by jenkins-bot:
Make Special:Notifications responsive

Checked in betalabs - the sidebar is suppressed; the page is usable, in terms of displaying and functionality. Checked with iPhone and Chrome mobile emulator (screenshots are below).

In iOS 9.3.2 (6s iPhone)
Notice that 'Preference' link is present (it's absent from desktop version).

IMG_1543 (2).PNG (1×640 px, 82 KB)

IMG_1542.PNG (1×640 px, 81 KB)

Chrome mobile emulator presents the view without 'Preferences' link

Screen Shot 2016-07-22 at 5.04.40 PM.png (613×500 px, 62 KB)

But when a link is, 'Preferences' link is displayed (the same as on a real device).

Screen Shot 2016-07-22 at 5.06.17 PM.png (606×565 px, 61 KB)

Thanks @Mooeypoo, can we make some adjustments here? I.e.,

  • is there a reason we can't suppress the preferences link? Also
  • When you and I went over the mobile layout, you hadn't added the cog in yet. Now it's floating on its own line. Would it be possible to move the cog up to be on the same line with the Read/Unread filters? Or on the line with the page title?
  • (If you can do that, then close up the space where the cog was about halfway after.)


Those were fixed up in the follow up commit --

It's merged now, it should work in beta.

Preference link is gone
The cog icon is displayed under the Read/Unread filters (makes sense since it's logically grouped together with pagination controls)
Without pagination

IMG_1555.PNG (1×640 px, 86 KB)

With pagination
IMG_1554.PNG (1×640 px, 82 KB)

The timestamps with weekdays are displayed now as e.g. 'Yesterday' or 'Friday' - filed as T141466: [betalabs] Mobile Special:Notifications page displays only weekday names

I'm seeing that the page doesn't fit on my iphone 5 screen. (See the screenshot below—as well as Elena's screnshots above.) This may be because the dotdotdot menus don't fit within the page frame when the links are longish? (See the second screenshot below.)

I see it also happens, though to a lesser degree, on the Notifications panel, which fits better but still has the dotdotdot problem, as you can see in the third screenshot (first message missing dotdot).

I don't know if it's worth the trouble to fix this; the page is usable, though ugly. @Mooeypoo, what do you think? What type of adjustments would be available and how much effort are they?

IMG_1167.PNG (1×640 px, 88 KB)

IMG_1168.PNG (1×640 px, 87 KB)

IMG_1169.PNG (1×640 px, 113 KB)

Resolving this, but moved the comment above to T141788