Page MenuHomePhabricator
Create Task
Maniphest T140851

Un-comment the wfWarn deprecations in all PHP entry points from all Wikimedia-deployed extensions and skins
Closed, ResolvedPublic
Actions

Details

Show related patches Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedNoneT140850 Remove all PHP entry points from all Wikimedia-deployed extensions and skins
ResolvedNoneT140851 Un-comment the wfWarn deprecations in all PHP entry points from all Wikimedia-deployed extensions and skins
ResolvedNoneT140852 Load all Wikimedia-deployed extensions and skins via extension registration
· · ·

Event Timeline

Jdforrester-WMF created this task.Jul 20 2016, 12:11 AM
Jdforrester-WMF created subtask T140852: Load all Wikimedia-deployed extensions and skins via extension registration.
Jdforrester-WMF added a comment.Jul 20 2016, 12:25 AM

We can't actually emit theses warnings right now, or we'll take down production with the logspam. But we really really should be doing so.

Legoktm added a subscriber: Legoktm.Oct 16 2018, 6:23 PM

I think we should be able to do this given that we've switched everything over to wfLoadExtension already.

gerritbot added a subscriber: gerritbot.Oct 16 2018, 6:25 PM

Change 467751 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ActiveAbstract@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467751

gerritbot added a project: Patch-For-Review.Oct 16 2018, 6:25 PM
gerritbot added a comment.Oct 16 2018, 6:27 PM

Change 467752 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Babel@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467752

gerritbot added a comment.Oct 16 2018, 6:28 PM

Change 467753 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/DismissableSiteNotice@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467753

gerritbot added a comment.Oct 16 2018, 6:29 PM

Change 467754 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/GuidedTour@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467754

gerritbot added a comment.Oct 16 2018, 6:29 PM

Change 467755 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/GWToolset@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467755

gerritbot added a comment.Oct 16 2018, 6:30 PM

Change 467756 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ImageMap@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467756

gerritbot added a comment.Oct 16 2018, 6:30 PM

Change 467757 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Interwiki@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467757

gerritbot added a comment.Oct 16 2018, 6:31 PM

Change 467758 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Josa@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467758

gerritbot added a comment.Oct 16 2018, 6:31 PM

Change 467759 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/JsonConfig@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467759

gerritbot added a comment.Oct 16 2018, 7:37 PM

Change 467756 merged by jenkins-bot:
[mediawiki/extensions/ImageMap@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467756

gerritbot added a comment.Oct 16 2018, 7:37 PM

Change 467753 merged by jenkins-bot:
[mediawiki/extensions/DismissableSiteNotice@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467753

gerritbot added a comment.Oct 16 2018, 7:45 PM

Change 467759 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467759

gerritbot added a comment.Oct 16 2018, 7:45 PM

Change 467758 merged by jenkins-bot:
[mediawiki/extensions/Josa@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467758

gerritbot added a comment.Oct 16 2018, 7:45 PM

Change 467757 merged by jenkins-bot:
[mediawiki/extensions/Interwiki@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467757

gerritbot added a comment.Oct 16 2018, 7:45 PM

Change 467752 merged by jenkins-bot:
[mediawiki/extensions/Babel@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467752

gerritbot added a comment.Oct 16 2018, 7:45 PM

Change 467751 merged by jenkins-bot:
[mediawiki/extensions/ActiveAbstract@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467751

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 16 2018, 8:01 PM
gerritbot added a comment.Oct 16 2018, 8:14 PM

Change 467754 merged by jenkins-bot:
[mediawiki/extensions/GuidedTour@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467754

gerritbot added a comment.Oct 16 2018, 8:14 PM

Change 467755 merged by jenkins-bot:
[mediawiki/extensions/GWToolset@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/467755

Ladsgroup removed a project: Patch-For-Review.May 28 2019, 3:37 PM
Ladsgroup closed subtask T140852: Load all Wikimedia-deployed extensions and skins via extension registration as Resolved.Aug 4 2020, 3:22 PM
gerritbot added a comment.Aug 4 2020, 4:17 PM

Change 618340 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralAuth@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/618340

gerritbot added a project: Patch-For-Review.Aug 4 2020, 4:17 PM
Jdforrester-WMF added a comment.Aug 4 2020, 4:24 PM

With CentralAuth, this appears done: https://codesearch.wmcloud.org/deployed/?q=%5C%2F%5C%2F%20wfWarn&i=nope&files=&repos=

gerritbot added a comment.Aug 4 2020, 4:37 PM

Change 618348 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Emit deprecation warning for php entry points

https://gerrit.wikimedia.org/r/618348

Jdforrester-WMF closed this task as Resolved.Aug 4 2020, 4:57 PM
Ladsgroup added a subscriber: Ladsgroup.Aug 4 2020, 5:01 PM

Actually OpenStackManager, LdapAuthentication, FlaggedRevs and Wikidata.org have them:
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikidata.org/+/e07db5378ca22ed90e8bef283f843566ab6d0123/WikidataOrg.php
https://gerrit.wikimedia.org/g/mediawiki/extensions/OpenStackManager/+/b42319f0e74d8d0fc6d0daad68d714121d8ae928/OpenStackManager.php

And some more but I'm not sure if we should reopen this ticket though. We should just drop the php entry points IMHO.

gerritbot added a comment.Aug 4 2020, 5:03 PM

Change 618340 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Warn if legacy PHP entry point is used

https://gerrit.wikimedia.org/r/618340

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 4 2020, 6:00 PM
gerritbot added a comment.Jul 2 2021, 2:19 PM

Change 618348 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Emit deprecation warning for php entry points

https://gerrit.wikimedia.org/r/618348

Jdforrester-WMF added a comment.Jul 2 2021, 2:32 PM

The legacy entry points are slowly being deleted, but for those remaining all have the wfWarn uncommented except for Wikidata.org now?

gerritbot added a comment.Jul 2 2021, 2:37 PM

Change 702975 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Wikidata.org@master] Follow-up ded7b75de0: Uncomment the wfWarn for deprecated entry

https://gerrit.wikimedia.org/r/702975

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 3:00 PM
gerritbot added a comment.Jul 2 2021, 4:52 PM

Change 702975 merged by jenkins-bot:

[mediawiki/extensions/Wikidata.org@master] Follow-up ded7b75de0: Uncomment the wfWarn for deprecated entry

https://gerrit.wikimedia.org/r/702975

Jdforrester-WMF added a comment.Jul 3 2021, 7:40 AM

Congratulations all!

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL