This is a subtask, no points. See parent task
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Feature flag language button in secondary actions | mediawiki/extensions/MobileFrontend | master | +26 -8 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T104893 [EPIC]: Simplify navigation on mobile web | |||
| Open | None | T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web | |||
| Resolved | ovasileva | T137932 [EPIC] Mobile language switching improvement work II | |||
| Resolved | • bmansurov | T130849 Clean up language button related code on mobile web (instrumentation + old feature flagged code) | |||
| Duplicate | None | T138962 Deploy mobile language button placement improvement to all wikis | |||
| Resolved | • Jhernandez | T146912 Subtask: Clean up `MinervaUsePageActionBarV2` on mobile web | |||
| Resolved | • Nirzar | T129505 Ship mobile web readily available language button placement affordance on Wednesday immediately following Tuesday single-language deployment | |||
| Resolved | dr0ptp4kt | T138961 Deploy mobile language button placement improvement to a larger-medium wiki on Tuesday week two of sprint | |||
| Resolved | dr0ptp4kt | T140260 Prepare mobile language button for deployment | |||
| Resolved | phuedx | T140872 [subtask] Feature flag language button at the bottom |
Change 299994 had a related patch set uploaded (by Jhernandez):
Feature flag language button in secondary actions
I haven't submitted JS code to disable the button when the flag is off in cached HTML pages, given it is not that important that is not there.
Change 299994 merged by jenkins-bot:
Feature flag language button in secondary actions
@dr0ptp4kt: If you decide to assign this to an engineer to sign off, then bear in mind that @Jhernandez worked on it.
@phuedx @Jdlrobson @bmansurov @jhobs would one of you please sign off if appropriate?
This LGTM.
Since this task is for togging the generation of content, rather than changing the display of content, I only tested it in one browser, Chrome (51.0.2704.106).
I tested the change as follows:
cd /path/to/mediawiki/extensions/MobileFrontend MEDIAWIKI_HOST=http://dev.wiki.local.wmftest.net:8080 ./dev-scripts/cachedpage.sh HEAD~1