Page MenuHomePhabricator
Create Task
Maniphest T140888

Re-implement listEntities() in EntityPerPageIdPager (and rename to SqlEntityIdPager)
Closed, ResolvedPublic
Actions

Description

EntityPerPageTable currently implements the listEntities() method based on wb_entity_per_page. This functionality should be re-implemented based on the page table in EntityPerPageIdPager (which should then be renamed to SqlEntityIdPager).

Details

SubjectRepoBranchLines +/-
Re-Implement SqlEntityIdPager without wb_entity_per_pagemediawiki/extensions/Wikibasemaster+252 -197
Move EntityPerPageTable::listEntities into SqlEntityIdPagermediawiki/extensions/Wikibasemaster+530 -500
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Jul 20 2016, 12:32 PM
Restricted Application added a subscriber: Zppix. · View Herald TranscriptJul 20 2016, 12:32 PM
daniel removed a parent task: T95685: Drop wb_entity_per_page table.Jul 20 2016, 12:36 PM
daniel added a parent task: T140890: Drop EntityPerPage service.
daniel mentioned this in T140758: Investigate where wb_entity_per_page table is used and needed.Jul 20 2016, 1:08 PM
matej_suchanek unsubscribed.Sep 15 2016, 4:58 PM
gerritbot added a comment.Oct 4 2016, 8:45 PM

Change 314164 had a related patch set uploaded (by Hoo man):
Move EntityPerPageTable::listEntities into SqlEntityIdPager

https://gerrit.wikimedia.org/r/314164

gerritbot added a project: Patch-For-Review.Oct 4 2016, 8:45 PM
hoo claimed this task.Oct 4 2016, 8:45 PM
hoo added a project: Wikidata-Sprint-2016-09-21.
hoo moved this task from Proposed to Review on the Wikidata-Sprint-2016-09-21 board.Oct 4 2016, 9:46 PM
gerritbot added a comment.Oct 6 2016, 8:27 AM

Change 314164 merged by jenkins-bot:
Move EntityPerPageTable::listEntities into SqlEntityIdPager

https://gerrit.wikimedia.org/r/314164

hoo moved this task from Review to Doing on the Wikidata-Sprint-2016-09-21 board.Oct 6 2016, 1:55 PM
hoo removed a project: Patch-For-Review.
gerritbot added a comment.Oct 10 2016, 3:23 PM

Change 315102 had a related patch set uploaded (by Hoo man):
Re-Implement SqlEntityIdPager without wb_entity_per_page

https://gerrit.wikimedia.org/r/315102

gerritbot added a project: Patch-For-Review.Oct 10 2016, 3:23 PM
hoo moved this task from Doing to Review on the Wikidata-Sprint-2016-09-21 board.Oct 10 2016, 3:27 PM
hoo added a project: Wikidata-Sprint-2016-10-12.Oct 20 2016, 2:55 PM
hoo moved this task from Proposed to Review on the Wikidata-Sprint-2016-10-12 board.
gerritbot added a comment.Nov 1 2016, 5:53 PM

Change 315102 merged by jenkins-bot:
Re-Implement SqlEntityIdPager without wb_entity_per_page

https://gerrit.wikimedia.org/r/315102

hoo closed this task as Resolved.Nov 2 2016, 11:52 AM
hoo removed a project: Patch-For-Review.
hoo moved this task from Review to Done on the Wikidata-Sprint-2016-10-12 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL