efSchemaValidate is a global function, and a blocker to extension registration in T87912. It's used outside EventLogging in UploadWizard, so needs a little more handling to make sure both patches are merged at the same time when it's moved to belonging to a class...
|Open||None||T119117 Get rid of $wg = $wmg hack for extensions that have been converted to using extension.json|
|Open||None||T140850 Remove all PHP entry points from all Wikimedia-deployed extensions and skins|
|Open||None||T140851 Un-comment the wfWarn deprecations in all PHP entry points from all Wikimedia-deployed extensions and skins|
|Open||None||T125678 Scap should not rely on extension-list, instead pass --extension-dir to mergeMessageFileList.php|
|Open||None||T140852 Load all Wikimedia-deployed extensions and skins via extension registration|
|Open||None||T87875 Convert all Wikimedia-deployed extensions and skins to use extension registration|
|Resolved||Tgr||T87912 Convert EventLogging to use extension registration|
|Resolved||Reedy||T140908 Move efSchemaValidate out of global scope|
Hold on… is efSchemaValidate() a generic function to validate some JSON data against some JSON schema? Why is it in EventLogging, and why, for all that is holy, do we use it in UploadWizard?
I'm pretty sure this is the same kind of JSON schema as the one used in MediaWiki core to validate extension.json files. That would imply MediaWiki core has a method to do this. Why do we need efSchemaValidate() at all?
[16:38:00] <marktraceur> Hmm Reedy does efSchemaValidate have a reasonable alternative in core yet? Last I checked it was lackluster.
[16:38:12] <Reedy> Not sure, I'd presume not
[16:38:26] <Reedy> I was gonna just move it to the "EventLogging" class for now
[16:38:32] <Reedy> UW seems to be the only other consumer
[16:39:50] <Reedy> marktraceur: Unless someone says just move it to core
[16:39:56] <marktraceur> Reedy: UW and now FileAnnotations :)
[16:40:06] <Reedy> orly?
[16:40:17] <marktraceur> I used the code from UW as a template, and when legoktm suggested the alternative, I found it to be lacking entirely
[16:40:38] <marktraceur> Reedy: We use efSchemaValidate to lay out the schema for the File Annotations namespace
<marktraceur> MatmaRex: Sorry, I'm not at my computer right now, but I last checked a week or two ago when I was writing the schema for FileAnnotations. <marktraceur> MatmaRex: And legoktm gave me a convoluted option that didn't seem like it would do the same thing anyway.
The library we use for extension.json validation doesn't support localized error messages. It's also only a dev-dependency right now, but it has passed security review and could become a required dependency.
Change 300755 abandoned by Krinkle:
Promote justinrainbow/json-schema from dev to always required
Closing in favour of potentially having UploadWizard use this directly in its own composer.json file (which we'd aggregate in mediawiki-vendor for wmf).