Page MenuHomePhabricator
Create Task
Maniphest T140959

SmashPig tasks which read from pending queue should compare to pending db
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Just like T140484, but for SmashPig tasks.

PaymentProviders\Adyen\Jobs\ProcessCaptureRequestJob
PaymentProviders\Adyen\Jobs\RecordCaptureJob

Details

SubjectRepoBranchLines +/-
Remove some unused message fieldswikimedia/fundraising/SmashPigmaster+0 -22
Only compare pending fields with valueswikimedia/fundraising/SmashPigmaster+8 -0
Use factory method instead of constructor for jobwikimedia/fundraising/SmashPigmaster+13 -8
Compare pending db/queue in Adyen RecordCaptureJobwikimedia/fundraising/SmashPigmaster+14 -0
Update pending db to match queue in Adyen capture jobwikimedia/fundraising/SmashPigmaster+105 -44
Compare pending db and queue in Adyen capture jobwikimedia/fundraising/SmashPigmaster+99 -24
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Jul 20 2016, 10:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2016, 10:52 PM
gerritbot subscribed.Jul 25 2016, 11:53 PM

Change 301026 had a related patch set uploaded (by Ejegg):
Compare pending db and queue in Adyen capture job

https://gerrit.wikimedia.org/r/301026

Ejegg claimed this task.Jul 25 2016, 11:53 PM
Ejegg added a project: Fundraising Sprint Nitpicking.
Ejegg set the point value for this task to 1.
gerritbot added a comment.Jul 26 2016, 3:51 PM

Change 301145 had a related patch set uploaded (by Ejegg):
WIP compare pending db/queue in RecordCaptureJob

https://gerrit.wikimedia.org/r/301145

gerritbot added a comment.Jul 26 2016, 5:08 PM

Change 301166 had a related patch set uploaded (by Ejegg):
Update pending db to match queue in Adyen capture job

https://gerrit.wikimedia.org/r/301166

• DStrine moved this task from Triage to Current Sprint & Completed in Q1 1617 on the Fundraising-Backlog board.Jul 26 2016, 5:12 PM
gerritbot added a comment.Jul 26 2016, 9:55 PM

Change 301026 merged by jenkins-bot:
Compare pending db and queue in Adyen capture job

https://gerrit.wikimedia.org/r/301026

Ejegg moved this task from Backlog to Review on the Fundraising Sprint Nitpicking board.Jul 26 2016, 11:27 PM
awight moved this task from Backlog to Pending consolidation on the FR-ActiveMQ board.Jul 27 2016, 9:00 PM
• DStrine changed the point value for this task from 1 to 2.Jul 29 2016, 8:24 PM
• DStrine added a project: Fundraising Sprint Octopus Untangling.Aug 3 2016, 10:49 PM
Ejegg moved this task from Backlog to Review on the Fundraising Sprint Octopus Untangling board.Aug 3 2016, 11:10 PM
awight moved this task from Review to Pending Deployment on the Fundraising Sprint Octopus Untangling board.Aug 4 2016, 11:56 PM
gerritbot added a comment.Aug 4 2016, 11:57 PM

Change 301166 merged by jenkins-bot:
Update pending db to match queue in Adyen capture job

https://gerrit.wikimedia.org/r/301166

gerritbot added a comment.Aug 4 2016, 11:57 PM

Change 301145 merged by jenkins-bot:
Compare pending db/queue in Adyen RecordCaptureJob

https://gerrit.wikimedia.org/r/301145

gerritbot added a comment.Aug 9 2016, 8:09 PM

Change 303862 had a related patch set uploaded (by Ejegg):
Use factory method instead of constructor for job

https://gerrit.wikimedia.org/r/303862

gerritbot added a comment.Aug 9 2016, 9:25 PM

Change 303862 merged by jenkins-bot:
Use factory method instead of constructor for job

https://gerrit.wikimedia.org/r/303862

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Octopus Untangling board.Aug 10 2016, 7:05 PM
Ejegg moved this task from Done to Doing on the Fundraising Sprint Octopus Untangling board.Aug 11 2016, 6:54 PM
gerritbot added a comment.Aug 11 2016, 6:56 PM

Change 304289 had a related patch set uploaded (by Ejegg):
Remove some unused message fields

https://gerrit.wikimedia.org/r/304289

gerritbot added a project: Patch-For-Review.Aug 11 2016, 6:56 PM
gerritbot added a comment.Aug 11 2016, 7:01 PM

Change 304293 had a related patch set uploaded (by Ejegg):
Only compare pending fields with values

https://gerrit.wikimedia.org/r/304293

Ejegg moved this task from Doing to Review on the Fundraising Sprint Octopus Untangling board.Aug 11 2016, 7:01 PM
gerritbot added a comment.Aug 11 2016, 8:00 PM

Change 304293 merged by jenkins-bot:
Only compare pending fields with values

https://gerrit.wikimedia.org/r/304293

Ejegg moved this task from Review to Done on the Fundraising Sprint Octopus Untangling board.Aug 11 2016, 10:33 PM
Ejegg closed this task as Resolved.Aug 17 2016, 6:01 PM
gerritbot added a comment.Aug 17 2016, 11:43 PM

Change 304289 merged by jenkins-bot:
Remove some unused message fields

https://gerrit.wikimedia.org/r/304289

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL