Page MenuHomePhabricator
Create Task
Maniphest T140965

The RevisionSlider should abort dragging&dropping if a user presses ESC
Closed, ResolvedPublic
Actions

Description

Currently, if I start dragging&dropping in the revision slider, and at the same time I press the Esc key on my keyboard, nothing happens.

It would be nice if the Esc key could cancel the dragging&dropping, as acceptable on computers.

Details

SubjectRepoBranchLines +/-
Fix handling of escape keymediawiki/extensions/RevisionSlidermaster+13 -12
Fix positioning error with draggable, revert and gridmediawiki/coremaster+5 -1
Introduce ESC key detection during dragging RevisionSlidermediawiki/extensions/RevisionSlidermaster+23 -2
Customize query in gerrit

Related Objects

Mentioned In
rERSL4ed98516102f: Fix handling of escape key
rERSL6e4c2232f5b4: Fix handling of escape key
rERSL8af607c980fc: Fix handling of escape key
rERSLf754cd0c6bb4: Fix handling of escape key
rERSLc6acc0cfc604: Fix handling of escape key
rERSL734a35d7067d: Fix handling of escape key
rERSLb33ccef6a88a: Fix handling of escape key
rERSLd3b9dae6039d: Fix handling of escape key
rERSL4a66a4ac106e: Fix handling of escape key
rERSL2212abb2712d: Fix handling of escape key
rERSL4ef2519bcca1: Fix handling of escape key
rERSLed988dc9a66b: Introduce ESC key detection during dragging RevisionSlider
rERSLb169f6237a3d: Introduce ESC key detection during dragging RevisionSlider
rERSL7ed3755cb74a: Introduce ESC key detection during dragging RevisionSlider
rERSL6d12816a5a5e: Introduce ESC key detection during dragging RevisionSlider
rERSL8a325bed2bb2: Introduce ESC key detection during dragging RevisionSlider
rERSL6a0d9e5e7ecd: Introduce ESC key detection during dragging RevisionSlider
rERSL480a37d18f7e: Introduce ESC key detection during dragging RevisionSlider
rERSL7c5e22c1f85b: Introduce ESC key detection during dragging RevisionSlider
rERSLf1d7f314eaea: Introduce ESC key detection during dragging RevisionSlider
rERSLd6d1ff93617a: Introduce ESC key detection during dragging RevisionSlider
rERSL63e54addabab: Introduce ESC key detection during dragging RevisionSlider
rERSL42c528fe5f16: Introduce ESC key detection during dragging RevisionSlider
rERSL33e83211f963: Introduce ESC key detection during dragging
rERSL2254c18104be: Introduce ESC key detection during dragging RevisionSlider
rERSLc98aa16e31a9: Introduces ESC key detection during dragging
rERSL2eea144e77a8: Introduces ESC key detection during dragging

Event Timeline

Guycn2 created this task.Jul 21 2016, 3:16 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptJul 21 2016, 3:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore moved this task from Incoming to Revision Slider on the TCB-Team (now WMDE-TechWish) board.Jul 22 2016, 9:07 AM
Lea_WMDE moved this task from Incoming to Backlog on the Revision-Slider board.Aug 2 2016, 9:47 AM
Addshore added a project: good first task.Oct 26 2016, 3:01 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 26 2016, 3:01 PM
Addshore added a project: Google-Code-In-2016.Nov 3 2016, 8:18 PM
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-In-2016 board.Nov 27 2016, 11:55 PM

Imported as https://codein.withgoogle.com/tasks/5083462419611648/

gerritbot subscribed.Dec 7 2016, 8:59 PM

Change 325823 had a related patch set uploaded (by Pppery):
Introduces ESC key detection during dragging

https://gerrit.wikimedia.org/r/325823

gerritbot added a project: Patch-For-Review.Dec 7 2016, 8:59 PM
Pppery mentioned this in rERSL2eea144e77a8: Introduces ESC key detection during dragging.Dec 7 2016, 9:02 PM
Pppery mentioned this in rERSLc98aa16e31a9: Introduces ESC key detection during dragging.Dec 7 2016, 9:06 PM
Pppery mentioned this in rERSL2254c18104be: Introduce ESC key detection during dragging RevisionSlider.Dec 9 2016, 8:06 PM
Pppery mentioned this in rERSL33e83211f963: Introduce ESC key detection during dragging.
Pppery mentioned this in rERSL42c528fe5f16: Introduce ESC key detection during dragging RevisionSlider.Dec 10 2016, 7:45 PM
Pppery mentioned this in rERSL63e54addabab: Introduce ESC key detection during dragging RevisionSlider.Dec 10 2016, 7:49 PM
Pppery mentioned this in rERSLd6d1ff93617a: Introduce ESC key detection during dragging RevisionSlider.Dec 10 2016, 8:38 PM
Pppery mentioned this in rERSLf1d7f314eaea: Introduce ESC key detection during dragging RevisionSlider.Dec 10 2016, 9:18 PM
Pppery mentioned this in rERSL7c5e22c1f85b: Introduce ESC key detection during dragging RevisionSlider.Dec 10 2016, 9:26 PM
Pppery mentioned this in rERSL480a37d18f7e: Introduce ESC key detection during dragging RevisionSlider.Dec 10 2016, 9:53 PM
divadsn mentioned this in rERSL6a0d9e5e7ecd: Introduce ESC key detection during dragging RevisionSlider.Dec 10 2016, 10:27 PM
Pppery mentioned this in rERSL8a325bed2bb2: Introduce ESC key detection during dragging RevisionSlider.Dec 11 2016, 1:27 PM
Tobi_WMDE_SW subscribed.Dec 14 2016, 8:30 AM
Tobi_WMDE_SW mentioned this in rERSL6d12816a5a5e: Introduce ESC key detection during dragging RevisionSlider.Dec 14 2016, 10:38 AM
Pppery mentioned this in rERSL7ed3755cb74a: Introduce ESC key detection during dragging RevisionSlider.Dec 19 2016, 8:33 PM
Tobi_WMDE_SW assigned this task to Pppery.Dec 20 2016, 12:37 PM
Tobi_WMDE_SW added a project: WMDE-TechWish.
Tobi_WMDE_SW moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.
Tobi_WMDE_SW moved this task from Backlog to Doing on the Revision-Slider board.Jan 10 2017, 10:45 AM
WMDE-Fisch subscribed.Jan 17 2017, 10:22 AM

In the current version of the proposed patch, when aborting the process at least more then once, the pointer randomly returns to a slightly different position then intended. See the video below.

in the second attempt the pointer returns to a position is (very) slightly above the original place. In the third attempt it returns to a position below. It seems to be random how big the misplacement is. Sometimes its more above, sometimes more below, sometimes its happening on the X-Axis.

WMDE-Fisch added a comment.Jan 17 2017, 4:27 PM

I could just confirm, that this seems to be a bug in jquery.ui.draggable. Core is using 1.9.2 at the moment and the bug is fixed starting with 1.11.4.

As already mentioned upgrading the libs in core is not trivial, since there might be breaking changes with other parts of the code or other extensions using them. The only alternative would be re-positioning the pointers when they return to their original place.

divadsn subscribed.Jan 19 2017, 11:40 PM
gerritbot added a comment.Jan 20 2017, 10:14 AM

Change 333224 had a related patch set uploaded (by WMDE-Fisch):
Fix positioning error with draggable, revert and grid

https://gerrit.wikimedia.org/r/333224

WMDE-Fisch mentioned this in rERSLb169f6237a3d: Introduce ESC key detection during dragging RevisionSlider.Jan 23 2017, 9:52 AM
WMDE-Fisch mentioned this in rERSLed988dc9a66b: Introduce ESC key detection during dragging RevisionSlider.
WMDE-Fisch moved this task from Currently in sprint to Done on the WMDE-TechWish board.Jan 30 2017, 1:23 PM
gerritbot added a comment.Jan 30 2017, 1:32 PM

Change 333224 merged by jenkins-bot:
Fix positioning error with draggable, revert and grid

https://gerrit.wikimedia.org/r/333224

gerritbot added a comment.Jan 30 2017, 1:32 PM

Change 325823 merged by jenkins-bot:
Introduce ESC key detection during dragging RevisionSlider

https://gerrit.wikimedia.org/r/325823

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 30 2017, 2:00 PM
Addshore closed this task as Resolved.Jan 31 2017, 12:59 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jan 31 2017, 3:19 PM
Tobi_WMDE_SW moved this task from Doing to Done on the Revision-Slider board.Feb 6 2017, 10:24 AM
Pppery removed a project: Patch-For-Review.Feb 9 2017, 2:34 PM
Pppery reopened this task as Open.May 18 2017, 1:29 AM

This doesn't seem to work anymore. Instead, pressing ESC has the same affect as letting go of the mouse, which changes the position of the pointers.

Pppery mentioned this in rERSL4ef2519bcca1: Fix handling of escape key.May 18 2017, 1:35 AM
Pppery mentioned this in rERSL2212abb2712d: Fix handling of escape key.
Pppery mentioned this in rERSL4a66a4ac106e: Fix handling of escape key.May 18 2017, 1:38 AM
gerritbot added a comment.May 18 2017, 1:44 AM

Change 354175 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/RevisionSlider@master] Fix handling of escape key

https://gerrit.wikimedia.org/r/354175

gerritbot added a project: Patch-For-Review.May 18 2017, 1:44 AM
Pppery mentioned this in rERSLd3b9dae6039d: Fix handling of escape key.May 18 2017, 1:45 AM
Pppery mentioned this in rERSLb33ccef6a88a: Fix handling of escape key.May 18 2017, 1:57 AM
Pppery mentioned this in rERSL734a35d7067d: Fix handling of escape key.
gerritbot added a comment.May 18 2017, 2:01 AM

Change 354175 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/RevisionSlider@master] Fix handling of escape key

https://gerrit.wikimedia.org/r/354175

Pppery mentioned this in rERSLc6acc0cfc604: Fix handling of escape key.May 18 2017, 2:01 AM
Pppery moved this task from Done to Incoming on the Revision-Slider board.May 18 2017, 10:56 PM
Pppery moved this task from Demoed to Proposed on the WMDE-TechWish board.
WMDE-Fisch mentioned this in rERSLf754cd0c6bb4: Fix handling of escape key.May 19 2017, 10:40 AM
Pppery mentioned this in rERSL8af607c980fc: Fix handling of escape key.May 19 2017, 7:08 PM
Pppery mentioned this in rERSL6e4c2232f5b4: Fix handling of escape key.May 19 2017, 7:12 PM
Lea_WMDE moved this task from Incoming to Doing on the Revision-Slider board.May 20 2017, 6:48 AM
Pppery mentioned this in rERSL4ed98516102f: Fix handling of escape key.May 22 2017, 7:28 PM
WMDE-Fisch moved this task from Proposed to Done on the WMDE-TechWish board.May 23 2017, 12:42 PM
gerritbot added a comment.May 23 2017, 12:54 PM

Change 354175 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Fix handling of escape key

https://gerrit.wikimedia.org/r/354175

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)).May 23 2017, 1:01 PM
Pppery closed this task as Resolved.May 23 2017, 7:05 PM

One more bug fixed - again

Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jun 6 2017, 2:31 PM
Tobi_WMDE_SW removed a project: WMDE-TechWish.Jun 7 2017, 12:02 PM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 3:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL