Page MenuHomePhabricator

Make ToC show up on all subpages of project hub and fetch all stuff from hub regardless of subpage type
Closed, ResolvedPublic

Description

Subpages will no longer be collaborationhub pages.

  • Subpages will be wikitext or collaborationlists
  • All subpages in allowed collaborationhb nammespaces will check for hub parents and include toc from first found parent

Subpage icon info will be moved to the hub using list-style interface (T141007). Subpages descriptions will simply be part of the page (section 0 in wikitext, description in collaborationlist)

Event Timeline

Harej triaged this task as Medium priority.Jul 22 2016, 4:13 PM
Harej edited subscribers, added: Bawolff; removed: Isarra.

Change 314166 had a related patch set uploaded (by Isarra):
Add Table of Contents to subpages of CollaborationHubs

https://gerrit.wikimedia.org/r/314166

Change 314166 merged by jenkins-bot:
Add Table of Contents to subpages of CollaborationHubs

https://gerrit.wikimedia.org/r/314166

I merged the patch but we have an issue when a hub is a subpage of another hub.

Screen Shot 2016-10-04 at 6.52.01 PM.png (577×1 px, 101 KB)

The error seems to have resolved itself; I guess some of the new styles weren't loading. If it comes up again we can file a task. However there's an issue involving recycling of class names; I'll submit a patch to fix that shortly.

I don't think it's caused by a class name re-use, but what is happening is that for some reason, when a hub is a subpage of another hub, the .mw-ckicon style is applied to the main hub image, causing it to be constrained to a 16px by 16px box (even though the loaded image is substantially bigger).

Change 314215 had a related patch set uploaded (by Harej):
Clarifying stylesheets

https://gerrit.wikimedia.org/r/314215

Change 314215 merged by jenkins-bot:
Clarifying stylesheets

https://gerrit.wikimedia.org/r/314215