Page MenuHomePhabricator
Create Task
Maniphest T141008

Make ToC show up on all subpages of project hub and fetch all stuff from hub regardless of subpage type
Closed, ResolvedPublic
Actions

Description

Subpages will no longer be collaborationhub pages.

  • Subpages will be wikitext or collaborationlists
  • All subpages in allowed collaborationhb nammespaces will check for hub parents and include toc from first found parent

Subpage icon info will be moved to the hub using list-style interface (T141007). Subpages descriptions will simply be part of the page (section 0 in wikitext, description in collaborationlist)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Clarifying stylesheetsmediawiki/extensions/CollaborationKitmaster+10 -5
Add Table of Contents to subpages of CollaborationHubsmediawiki/extensions/CollaborationKitmaster+305 -156
Customize query in gerrit

Related Objects
Search...

Event Timeline

Isarra created this task.Jul 21 2016, 5:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2016, 5:07 PM
Bawolff added a subtask: T141009: Add magic word to disable collabkit ToC.Jul 21 2016, 5:13 PM
Bawolff claimed this task.Jul 21 2016, 8:19 PM
Harej added a parent task: T138324: Security review for CollaborationKit.Jul 22 2016, 1:40 PM
Harej mentioned this in T138615: Consistent approach to replicating the WikiProject table of contents on all subpages.Jul 22 2016, 2:04 PM
Harej added a subtask: T140170: Separate out collaborationhub ToC into its own class.
Harej removed a subtask: T140170: Separate out collaborationhub ToC into its own class.Jul 22 2016, 4:04 PM
Harej added a parent task: T140170: Separate out collaborationhub ToC into its own class.
Harej removed a parent task: T138324: Security review for CollaborationKit.
Harej triaged this task as Medium priority.Jul 22 2016, 4:13 PM
Harej reassigned this task from Bawolff to Isarra.Sep 22 2016, 7:18 PM
Harej moved this task from Release blockers to In Progress on the MediaWiki-extensions-CollaborationKit board.
Harej edited subscribers, added: Bawolff; removed: Isarra.
gerritbot subscribed.Oct 4 2016, 9:01 PM

Change 314166 had a related patch set uploaded (by Isarra):
Add Table of Contents to subpages of CollaborationHubs

https://gerrit.wikimedia.org/r/314166

gerritbot added a project: Patch-For-Review.Oct 4 2016, 9:01 PM
Isarra mentioned this in rECKT97c37dd36b58: Add Table of Contents to subpages of CollaborationHubs.Oct 4 2016, 9:03 PM
Harej mentioned this in rECKTc5275d314328: Add Table of Contents to subpages of CollaborationHubs.Oct 4 2016, 10:41 PM
gerritbot added a comment.Oct 4 2016, 10:49 PM

Change 314166 merged by jenkins-bot:
Add Table of Contents to subpages of CollaborationHubs

https://gerrit.wikimedia.org/r/314166

Harej subscribed.Oct 4 2016, 10:54 PM

I merged the patch but we have an issue when a hub is a subpage of another hub.

Screen Shot 2016-10-04 at 6.52.01 PM.png (577×1 px, 101 KB)

Harej added a comment.Oct 5 2016, 12:34 AM

The error seems to have resolved itself; I guess some of the new styles weren't loading. If it comes up again we can file a task. However there's an issue involving recycling of class names; I'll submit a patch to fix that shortly.

Harej added a comment.Oct 5 2016, 12:50 AM

I don't think it's caused by a class name re-use, but what is happening is that for some reason, when a hub is a subpage of another hub, the .mw-ckicon style is applied to the main hub image, causing it to be constrained to a 16px by 16px box (even though the loaded image is substantially bigger).

gerritbot added a comment.Oct 5 2016, 1:28 AM

Change 314215 had a related patch set uploaded (by Harej):
Clarifying stylesheets

https://gerrit.wikimedia.org/r/314215

gerritbot added a comment.Oct 5 2016, 1:30 AM

Change 314215 merged by jenkins-bot:
Clarifying stylesheets

https://gerrit.wikimedia.org/r/314215

Harej closed this task as Resolved.Oct 5 2016, 1:32 AM
Harej moved this task from In Progress to Done on the MediaWiki-extensions-CollaborationKit board.
Harej mentioned this in rECKTa1f1da6a1fc8: Clarifying stylesheets.Oct 5 2016, 1:33 AM
Bawolff closed subtask T141009: Add magic word to disable collabkit ToC as Resolved.Oct 27 2016, 1:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits