Page MenuHomePhabricator

Centralize conversion of an elasticsearch hit into a Title object
Closed, ResolvedPublic

Description

With multi-project indices the result is not necessarily local. We need some method to determine what wiki a hit belongs to and create an appropriate title, interwiki if necessary. This should probably be gated on the wiki field? This should also be centralized so we don't duplicate the code in the various places that might want to convert a hit into a mediawiki Title.

Event Timeline

EBernhardson moved this task from needs triage to This Quarter on the Discovery-Search board.
debt moved this task from Up Next to Current work on the Discovery-Search board.Oct 11 2016, 5:20 PM
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.

Change 320625 had a related patch set uploaded (by DCausse):
[WIP] Refactor interwiki support

https://gerrit.wikimedia.org/r/320625

Change 320757 had a related patch set uploaded (by DCausse):
[WIP] Add and implement InterwikiResolver

https://gerrit.wikimedia.org/r/320757

Change 320788 had a related patch set uploaded (by DCausse):
Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788

Change 320757 merged by jenkins-bot:
Add and implement InterwikiResolver

https://gerrit.wikimedia.org/r/320757

Change 320625 merged by jenkins-bot:
Refactor interwiki support

https://gerrit.wikimedia.org/r/320625

Deskana closed this task as Resolved.Dec 9 2016, 3:18 PM

Change 341507 had a related patch set uploaded (by dcausse):
[mediawiki/extensions/CirrusSearch] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/341507

Change 341508 had a related patch set uploaded (by dcausse):
[mediawiki/extensions/CirrusSearch] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/341508

Change 320788 abandoned by DCausse:
Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788

Change 341507 abandoned by DCausse:
Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/341507

Change 320788 restored by EBernhardson:
Remove BC code after interwiki refactoring

Reason:
didn't manage to merge this into es5, need to un-abandon to push latest version

https://gerrit.wikimedia.org/r/320788

Change 320788 had a related patch set uploaded (by EBernhardson; owner: DCausse):
[mediawiki/extensions/CirrusSearch] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788

Change 341508 abandoned by EBernhardson:
Remove BC code after interwiki refactoring

Reason:
restored master branch patch

https://gerrit.wikimedia.org/r/341508

Change 320788 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788