Page MenuHomePhabricator
Create Task
Maniphest T141033

Centralize conversion of an elasticsearch hit into a Title object
Closed, ResolvedPublic
Actions

Description

With multi-project indices the result is not necessarily local. We need some method to determine what wiki a hit belongs to and create an appropriate title, interwiki if necessary. This should probably be gated on the wiki field? This should also be centralized so we don't duplicate the code in the various places that might want to convert a hit into a mediawiki Title.

Details

SubjectRepoBranchLines +/-
Remove BC code after interwiki refactoringmediawiki/extensions/CirrusSearchmaster+52 -167
Remove BC code after interwiki refactoringmediawiki/extensions/CirrusSearches5+47 -160
Remove BC code after interwiki refactoringmediawiki/extensions/CirrusSearchmaster+52 -160
Add and implement InterwikiResolvermediawiki/extensions/CirrusSearchmaster+15 K -0
Refactor interwiki supportmediawiki/extensions/CirrusSearchmaster+407 -233
Customize query in gerrit

Related Objects
Search...

Event Timeline

EBernhardson created this task.Jul 21 2016, 6:47 PM
EBernhardson moved this task from needs triage to This Quarter on the Discovery-Search board.
debt moved this task from This Quarter to Current work on the Discovery-Search board.Sep 20 2016, 5:50 PM
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.
EBernhardson edited projects, added Discovery-Search; removed Discovery-Search (Current work).Sep 27 2016, 5:04 PM
EBernhardson moved this task from needs triage to Up Next on the Discovery-Search board.
debt moved this task from Up Next to Current work on the Discovery-Search board.Oct 11 2016, 5:20 PM
debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse claimed this task.Oct 24 2016, 2:19 PM
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot subscribed.Nov 9 2016, 6:19 PM

Change 320625 had a related patch set uploaded (by DCausse):
[WIP] Refactor interwiki support

https://gerrit.wikimedia.org/r/320625

gerritbot added a project: Patch-For-Review.Nov 9 2016, 6:19 PM
gerritbot added a comment.Nov 10 2016, 11:01 AM

Change 320757 had a related patch set uploaded (by DCausse):
[WIP] Add and implement InterwikiResolver

https://gerrit.wikimedia.org/r/320757

gerritbot added a comment.Nov 10 2016, 3:35 PM

Change 320788 had a related patch set uploaded (by DCausse):
Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788

dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Nov 11 2016, 5:28 PM
gerritbot added a comment.Nov 17 2016, 5:24 PM

Change 320757 merged by jenkins-bot:
Add and implement InterwikiResolver

https://gerrit.wikimedia.org/r/320757

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 17 2016, 6:00 PM
Nemo_bis subscribed.Dec 5 2016, 9:48 AM
gerritbot added a comment.Dec 5 2016, 6:07 PM

Change 320625 merged by jenkins-bot:
Refactor interwiki support

https://gerrit.wikimedia.org/r/320625

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)).Dec 5 2016, 7:00 PM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Dec 8 2016, 11:48 PM
• Deskana closed this task as Resolved.Dec 9 2016, 3:18 PM
gerritbot added a comment.Mar 7 2017, 9:09 AM

Change 341507 had a related patch set uploaded (by dcausse):
[mediawiki/extensions/CirrusSearch] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/341507

gerritbot added a comment.Mar 7 2017, 9:12 AM

Change 341508 had a related patch set uploaded (by dcausse):
[mediawiki/extensions/CirrusSearch] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/341508

gerritbot added a comment.Mar 7 2017, 9:12 AM

Change 320788 abandoned by DCausse:
Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788

gerritbot added a comment.Mar 7 2017, 9:12 AM

Change 341507 abandoned by DCausse:
Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/341507

gerritbot added a comment.Mar 9 2017, 5:45 PM

Change 320788 restored by EBernhardson:
Remove BC code after interwiki refactoring

Reason:
didn't manage to merge this into es5, need to un-abandon to push latest version

https://gerrit.wikimedia.org/r/320788

gerritbot added a comment.Mar 9 2017, 5:45 PM

Change 320788 had a related patch set uploaded (by EBernhardson; owner: DCausse):
[mediawiki/extensions/CirrusSearch] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788

gerritbot added a comment.Mar 9 2017, 5:45 PM

Change 341508 abandoned by EBernhardson:
Remove BC code after interwiki refactoring

Reason:
restored master branch patch

https://gerrit.wikimedia.org/r/341508

gerritbot added a comment.Apr 13 2017, 8:57 PM

Change 320788 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove BC code after interwiki refactoring

https://gerrit.wikimedia.org/r/320788

ReleaseTaggerBot edited projects, added MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)); removed MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Apr 13 2017, 9:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL