Page MenuHomePhabricator

Reconsider styling of excerpts within bundles in light of fact that they have no close quote
Closed, ResolvedPublic

Description

Because of the way we truncate ellipses in the panel, it's impossible to append close quotes to the end of the excerpt. So they start with a quote but then end with ellipses. See below.

It is important to indicate clearly that the excerpts are quote, not from the system. But we don't use quotation marks anywhere but bundles right now. I know Pau would like the excerpts to be gray. Perhaps some combination of gray or gray and italic would remove the need for quotation marks? See the mockup below:

Details

Related Gerrit Patches:
mediawiki/extensions/Echo : masterMake excerpts in bundles not italic, but still grey
mediawiki/extensions/Flow : masterItalicize post excerpts inside bundles
mediawiki/extensions/Echo : masterUse body color (gray) for <em>s in bundle headers

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2016, 6:49 PM

Change 300685 had a related patch set uploaded (by Catrope):
Use body color (gray) for <em>s in bundle headers

https://gerrit.wikimedia.org/r/300685

Change 299916 had a related patch set uploaded (by Catrope):
Italicize post excerpts inside bundles

https://gerrit.wikimedia.org/r/299916

Note that the gray italic message excerpts were put in place (as part of a different ticket), but we're still waiting for @Pginer-WMF's OK to move this ticket forward.

Note that the gray italic message excerpts were put in place (as part of a different ticket), but we're still waiting for @Pginer-WMF's OK to move this ticket forward.

I'm ok in getting rid of the quotes if there are technical limitations.
Making the text grey works well and it is aligned with he treatment on similar contexts.
I'd avoid the use of italics since it may make it harder to read, and we don't use it in other similar contexts.

So compared to the current state, what should we change? Just remove the italics but keep the grey and keep the absence of quotes?

So compared to the current state, what should we change? Just remove the italics but keep the grey and keep the absence of quotes?

Yes. That summarises perfectly what I was proposing.

Change 305051 had a related patch set uploaded (by Catrope):
Make excerpts in bundles not italic, but still grey

https://gerrit.wikimedia.org/r/305051

Should the new-topic bundled message be revisited as well? It is currently bold with quotes but the closing quote is often hidden by browser truncation.

"notification-compact-header-flow-new-topic": "\"<strong>$1</strong>\"",

Change 305051 merged by jenkins-bot:
Make excerpts in bundles not italic, but still grey

https://gerrit.wikimedia.org/r/305051

@SBisson asks:

Should the new-topic bundled message be revisited as well? It is currently bold with quotes but the closing quote is often hidden by browser truncation.

@Etonkovidova, do you know if this got fixed by T140523 (which caused the bundled notifications to wrap)?

jmatazzoni closed this task as Resolved.Aug 31 2016, 11:02 PM