Page MenuHomePhabricator
Create Task
Maniphest T141120

Move TrustedXFF away from CDB to static PHP array
Closed, ResolvedPublic
Actions

Description

Like most other CDB usages, TrustedXFF should have the option of using a static array in a PHP file instead of CDB.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Swap to using static php array for TrustedXFF usageoperations/mediawiki-configmaster+2 -2
Support reading/writing data to/from a static PHP arraymediawiki/extensions/TrustedXFFmaster+46 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Jul 22 2016, 4:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2016, 4:35 PM
Reedy mentioned this in T141125: Rebuild and deploy trusted-xff.Jul 22 2016, 4:51 PM
ori renamed this task from Move TrustedXFF away from CDB to json file to Move TrustedXFF away from CDB to static PHP array.Jul 22 2016, 5:51 PM
ori updated the task description. (Show Details)
gerritbot subscribed.Jul 22 2016, 6:05 PM

Change 300587 had a related patch set uploaded (by Ori.livneh):
Support reading/writing data to/from a static PHP array

https://gerrit.wikimedia.org/r/300587

gerritbot added a project: Patch-For-Review.Jul 22 2016, 6:05 PM
Reedy assigned this task to ori.Jul 25 2016, 10:26 PM
Reedy triaged this task as Medium priority.
gerritbot added a comment.Jul 25 2016, 10:35 PM

Change 301016 had a related patch set uploaded (by Reedy):
Swap to using static php array for TrustedXFF usage

https://gerrit.wikimedia.org/r/301016

Reedy edited projects, added MediaWiki-extensions-TrustedXFF; removed MediaWiki-extensions-Other.Jul 25 2016, 10:50 PM
Reedy added a parent task: T141125: Rebuild and deploy trusted-xff.
gerritbot added a comment.Jul 25 2016, 10:55 PM

Change 300587 merged by jenkins-bot:
Support reading/writing data to/from a static PHP array

https://gerrit.wikimedia.org/r/300587

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)).Jul 26 2016, 12:00 AM
Reedy closed this task as Resolved.Aug 6 2016, 11:03 PM

Done, needs config update when rebuilt

gerritbot added a comment.Aug 6 2016, 11:24 PM

Change 301016 abandoned by Reedy:
Swap to using static php array for TrustedXFF usage

https://gerrit.wikimedia.org/r/301016

• Krinkle added a parent task: T212460: Adopt static array files for local disk storage of values (epic).Dec 20 2018, 9:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits