In order to discontinue the use of OkHttp's deprecated OkUrlFactory API, we need to eliminate our dependency on the apps-android-java-mwapi library, which (like OkUrlFactory) is based on Java's HttpURLConnection API. More concretely, some of our API calls via HttpRequest (specifically, for login and account creation) depend on the cookie handling that OkHttp provides, and it's not worth the trouble to come up with an alternative cookie handling facility for a library we're in the process of phasing out.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Remove dependency on apps-android-java-mwapi library | Yashasvi | apps/android/wikipedia | master | +11 -154 |
Event Timeline
Comment Actions
@Mholloway this task is quite large. I know you've done a lot of work on it already. If it's helpful, I wanted to encourage the option of adding subtasks so we can include one or two every sprint until the epic is complete. (There can even be an initial spike task to identify remaining work, if needed.)
Comment Actions
@Niedzielski Good idea. It would be nice to have an exact understanding of the scope of work remaining here. Created a spike ticket.
Comment Actions
This probably isn't really a high priority if "thing will break" isn't a scenario we're facing in any certain time frame. Downgrading to normal.
Comment Actions
Change 361294 had a related patch set uploaded (by Yashasvi; owner: Yashasvi):
[apps/android/wikipedia@master] Remove dependency on apps-android-java-mwapi library
Comment Actions
Change 361294 merged by jenkins-bot:
[apps/android/wikipedia@master] Remove dependency on apps-android-java-mwapi library