Page MenuHomePhabricator

Notifications page: remove mw-echo-special-header-link
Closed, ResolvedPublic

Description

Per @jmatazzoni comment on T115528: Turn the cog icon into a menu

Meanwhile, what about the much simpler issue I pointed out above:

@Mooeypoo, on Beta I see the cog now but I still see the Preferences link underneath the page title. Since that link has >been made redundant, I'm pretty sure it's meant to be removed, yes?

If there's no reason to keep that redundant link, please remove it. Thanks.

mw-echo-special-header-link should be removed

Screen Shot 2016-07-22 at 11.21.28 AM.png (414×1 px, 91 KB)

Event Timeline

Change 300671 had a related patch set uploaded (by Mooeypoo):
Hide the 'preferences' link from Special:Notifications JS

https://gerrit.wikimedia.org/r/300671

Change 300671 merged by jenkins-bot:
Hide the 'preferences' link from Special:Notifications JS

https://gerrit.wikimedia.org/r/300671

Checked the fix in betalabs.

Before the fix:

Screen Shot 2016-07-22 at 3.09.02 PM.png (422×1 px, 98 KB)

JS page after the fix:
Screen Shot 2016-07-22 at 4.46.17 PM.png (381×1 px, 77 KB)

no-JS page:
Screen Shot 2016-07-22 at 4.48.42 PM.png (364×1 px, 60 KB)

Thanks for removing preferences. But now the space between the line under the page title and the page contents -- where the preferences link was -- is a little too tight now. Can you please blow a little more air in there? Make it more like the screenshot below please. Thanks.

page margin.jpg (421×1 px, 58 KB)