Page MenuHomePhabricator

Notifications page: remove mw-echo-special-header-link
Closed, ResolvedPublic

Description

Per @jmatazzoni comment on T115528: Turn the cog icon into a menu

Meanwhile, what about the much simpler issue I pointed out above:

@Mooeypoo, on Beta I see the cog now but I still see the Preferences link underneath the page title. Since that link has >been made redundant, I'm pretty sure it's meant to be removed, yes?

If there's no reason to keep that redundant link, please remove it. Thanks.

mw-echo-special-header-link should be removed

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2016, 6:31 PM

Change 300671 had a related patch set uploaded (by Mooeypoo):
Hide the 'preferences' link from Special:Notifications JS

https://gerrit.wikimedia.org/r/300671

Change 300671 merged by jenkins-bot:
Hide the 'preferences' link from Special:Notifications JS

https://gerrit.wikimedia.org/r/300671

Checked the fix in betalabs.

Before the fix:


JS page after the fix:

no-JS page:

Thanks for removing preferences. But now the space between the line under the page title and the page contents -- where the preferences link was -- is a little too tight now. Can you please blow a little more air in there? Make it more like the screenshot below please. Thanks.

jmatazzoni closed this task as Resolved.Jul 27 2016, 5:42 PM