Page MenuHomePhabricator

CentralNotice geotargeting broken
Open, NormalPublic

Description

With selecting in the CentralNotice system the option Geotargeted, and selecting only one country (in this case the Netherlands), then saving page, all countries are selected when checking.

This bug was noticed with setting up:
https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail&notice=WMNL+LGBT+2016&uselang=en

In this way the CentralNotice system can't be used properly, so fix is needed fast.

Event Timeline

Romaine created this task.Jul 25 2016, 4:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2016, 4:17 AM
Romaine updated the task description. (Show Details)Jul 25 2016, 4:18 AM
Romaine triaged this task as High priority.Jul 25 2016, 4:25 AM

Confirmed. I also just tried selecting Netherlands there and submitting it but all the countries are selected after submission. A log entry does get inserted but it's a blank one. https://meta.wikimedia.org/wiki/Special:CentralNoticeLogs?log_type=campaignSettings&startDate=&startDate_timestamp=&endDate=&endDate_timestamp=&campaign=WMNL+LGBT+2016&user=&centralnoticesubmit=Apply+filters

Confirmed on this particular campaign. However This doesn't seem to be affecting all campaign setup.

@Romaine : I've created a new campaign for you with the setup and will look further into this issue

https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail&notice=WMNL+LGBT+2016+2nd+Attempt

AndyRussG added a subscriber: AndyRussG.EditedJul 25 2016, 12:20 PM

Pretty sure this is a bug related to the multi-select control, and, hopefully, one that only happens in not-so-common circumstances... Looks like it's still happening with the original campaign. Looking into it there...

Thx!! :)

(Edit: removed repetitive stuff following @Jseddon's post.)

I have recreated the fault:

https://meta.wikimedia.org/w/index.php?title=Special:CentralNotice&subaction=noticeDetail&notice=Seddon_CN_Triage

The fault occurs in at least one way where the user:

  • Selects all countries
  • Saves
  • Then changes from select all to just a single country
Jseddon lowered the priority of this task from High to Normal.Jul 25 2016, 12:36 PM

@Jseddon Cool, thx! Just confirmed that this happens locally too. Same problem for the language selector, also, BTW.

Teles added a subscriber: Teles.Jul 26 2016, 4:24 AM