Page MenuHomePhabricator
Create Task
Maniphest T141274

[BUG] Crash when Tapping on a Lead Image of an Article that doesn't have any Images
Closed, ResolvedPublic
Actions

Description

Steps to reproduce

  1. 1. Open enwiki > Bishop McDevitt High School (Wyncote, Pennsylvania)
  2. 2. Tap on the Lead Image
  3. 3. Attempt to swipe left

Expected results

  1. Image appears
  2. Nothing

Actual results

  1. Blank Screen
  2. Crash

Screenshots

Environments observed

App version: 903.1
OS versions:
Device model:
Device language:

Notes

This is a regression - the same steps work fine in 5.0.4

Event Timeline

JoeWalsh created this task.Jul 25 2016, 4:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2016, 4:44 PM
JoeWalsh added a comment.Jul 25 2016, 4:44 PM

Fix: https://github.com/wikimedia/wikipedia-ios/pull/788

• Fjalapeno triaged this task as Medium priority.Jul 25 2016, 5:32 PM
• Fjalapeno added a project: iOS-app-v5.1.0-Saturn.
• Fjalapeno moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
Danny_B added a project: Regression.Jul 29 2016, 1:15 PM
• Fjalapeno moved this task from Backlog to Needs Testing Criteria on the iOS-app-v5.1.0-Saturn board.Jul 29 2016, 3:42 PM
• Fjalapeno subscribed.Aug 11 2016, 5:28 PM

To test:

Follow the steps in the ticket description

• Fjalapeno moved this task from Needs Testing Criteria to Needs QA on the iOS-app-v5.1.0-Saturn board.Aug 11 2016, 5:29 PM
Josve05a subscribed.EditedAug 12 2016, 1:40 AM

Following the steps in the description, ths seems to have been fixed.

Environments observed

App version: 908.1
OS versions: iOS 9.3.3
Device model: iPad mini 1
Device language: English

Nicholas.tsg subscribed.Aug 14 2016, 2:08 AM

I'm testing on iOS 9.3.4 and Wikipedia 5.1.0 (901). On the Bishop McDevitt High School (Wyncote, Pennsylvania) article, swiping left and right on the Lead Image passes the "bounce" test, so this is fixed.

Nicholas.tsg moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.1.0-Saturn board.Aug 14 2016, 2:08 AM
• JMinor closed this task as Resolved.Aug 17 2016, 1:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL