Page MenuHomePhabricator
Create Task
Maniphest T141369

Fix font support on SauceLabs VE screenshots
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Failures at normal size:
KM (Khmer)

pasted_file (186×410 px, 13 KB)

Failures when scaled up:
AZB (South Azerbaijaini)

pasted_file (100×270 px, 1 KB)

AR (Arabic)

pasted_file (100×222 px, 1 KB)

FA (Farsi)

pasted_file (100×222 px, 1 KB)

JA (Japanese)

pasted_file (100×190 px, 1 KB)

KM (Khmer)

pasted_file (186×410 px, 13 KB)

pasted_file (100×275 px, 1 KB)

KN Kannada

pasted_file (100×275 px, 1 KB)

OR (Odia/Oriya)

pasted_file (100×275 px, 1 KB)

PS (Pashto)

pasted_file (100×174 px, 1 KB)

SD (Sindhi)

pasted_file (100×206 px, 1 KB)

TA (Tamil)

pasted_file (100×275 px, 1 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+1 -1Run language screenshots on Windows
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Jul 26 2016, 3:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2016, 3:14 PM
Esanders assigned this task to zeljkofilipin.Jul 26 2016, 3:24 PM
Esanders updated the task description. (Show Details)
Jdforrester-WMF triaged this task as Medium priority.Jul 26 2016, 7:03 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Esanders added a comment.Aug 1 2016, 3:25 PM

Is this because it runs on a Windows box? Can we change it to use Linux?

Jdforrester-WMF set the point value for this task to 0.Aug 12 2016, 8:24 PM
zeljkofilipin added a comment.Aug 16 2016, 8:00 AM

@Esanders apologies for the late reply, I was on vacation. As far as I remember, the best font support was on Mac. I will change the OS to Mac and Linux and see which one is the best.

zeljkofilipin added projects: Browser-Tests-Infrastructure, User-zeljkofilipin.Aug 18 2016, 11:32 AM
zeljkofilipin moved this task from Backlog ⏪ to In Progress 🏋️‍♂️ on the User-zeljkofilipin board.
zeljkofilipin moved this task from Inbox to Next on the Browser-Tests-Infrastructure board.
zeljkofilipin moved this task from In Progress 🏋️‍♂️ to Next ⏭ on the User-zeljkofilipin board.
zeljkofilipin added a comment.Aug 20 2016, 12:50 PM

I am not sure what the problem is here. The screenshots look fine to me.

zeljkofilipin moved this task from Next ⏭ to In Progress 🏋️‍♂️ on the User-zeljkofilipin board.Aug 20 2016, 12:53 PM
zeljkofilipin moved this task from Backlog to Doing on the VisualEditor-MediaWiki board.Aug 20 2016, 1:05 PM
zeljkofilipin moved this task from Next to In Progress on the Browser-Tests-Infrastructure board.

screenshots.yml says the job is running on Linux:

BROWSER:
  - chrome

PLATFORM:
 - Linux
gerritbot added a subscriber: gerritbot.Aug 20 2016, 1:10 PM

Change 305786 had a related patch set uploaded (by Zfilipin):
WIP Run language screenshots on OS X 10.11

https://gerrit.wikimedia.org/r/305786

gerritbot added a project: Patch-For-Review.Aug 20 2016, 1:10 PM
zeljkofilipin added a subscriber: Amire80.Aug 22 2016, 8:08 AM
zeljkofilipin added a parent task: T139613: Run language screenshots script for VisualEditor in Jenkins.Aug 22 2016, 8:20 AM
zeljkofilipin added a comment.Aug 22 2016, 2:17 PM
This comment was removed by zeljkofilipin.
zeljkofilipin added a comment.EditedAug 23 2016, 10:42 AM

The job is running using Chrome browser.

Linux, #26, 2 hr 33 min, 801 passing, 5 failing, 1.785 filesMac, #27, 3 hr 16 min, timed out, 846 filesMac, #28, 3 hr 2 min, 279 passing, 86 failing, 821 filesWindows, #30, 3 hr 10 min, 737 passing, 18 failing, 1.894 files
ar
VisualEditor_toolbar-ar.png (81×1 px, 25 KB)
VisualEditor_toolbar-ar.png (81×1 px, 27 KB)
VisualEditor_toolbar-ar.png (81×841 px, 23 KB)
azb
VisualEditor_toolbar-azb.png (81×1 px, 25 KB)
VisualEditor_toolbar-azb.png (81×1 px, 28 KB)
VisualEditor_toolbar-azb.png (81×841 px, 23 KB)
fa
VisualEditor_toolbar-fa.png (81×1 px, 25 KB)
VisualEditor_toolbar-fa.png (81×1 px, 26 KB)
VisualEditor_toolbar-fa.png (81×841 px, 23 KB)
ja
VisualEditor_toolbar-ja.png (81×1 px, 28 KB)
VisualEditor_toolbar-ja.png (81×1 px, 29 KB)
VisualEditor_toolbar-ja.png (81×841 px, 24 KB)
km
VisualEditor_toolbar-km.png (81×1 px, 29 KB)
VisualEditor_toolbar-km.png (81×1 px, 30 KB)
VisualEditor_toolbar-km.png (81×841 px, 25 KB)
kn
VisualEditor_toolbar-kn.png (81×1 px, 29 KB)
VisualEditor_toolbar-kn.png (81×1 px, 31 KB)
VisualEditor_toolbar-kn.png (121×841 px, 29 KB)
or
VisualEditor_toolbar-or.png (81×1 px, 28 KB)
VisualEditor_toolbar-or.png (81×1 px, 32 KB)
VisualEditor_toolbar-or.png (81×841 px, 27 KB)
ps
VisualEditor_toolbar-ps.png (81×1 px, 26 KB)
VisualEditor_toolbar-ps.png (81×1 px, 28 KB)
VisualEditor_toolbar-ps.png (81×841 px, 24 KB)
sd
VisualEditor_toolbar-sd.png (81×1 px, 25 KB)
VisualEditor_toolbar-sd.png (81×1 px, 28 KB)
VisualEditor_toolbar-sd.png (81×841 px, 24 KB)
ta
VisualEditor_toolbar-ta.png (81×1 px, 26 KB)
VisualEditor_toolbar-ta.png (121×841 px, 25 KB)
zeljkofilipin added a subscriber: Elitre.Aug 24 2016, 2:41 PM

@Esanders @Amire80 @Elitre: Please take a look at the screenshots and let me know which OS is preferred.

gerritbot added a comment.Aug 24 2016, 2:50 PM

Change 305786 merged by jenkins-bot:
Run language screenshots on Windows

https://gerrit.wikimedia.org/r/305786

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)).Aug 24 2016, 3:00 PM
Elitre added a comment.Aug 24 2016, 3:38 PM

The last one for Tamil doesn't look right?

Elitre added a subscriber: Whatamidoing-WMF.Aug 24 2016, 3:39 PM
zeljkofilipin added a comment.Aug 24 2016, 4:00 PM

@Elitre sorry, you will have to be more specific :) there are a lot of screenshots around. Are you referring to the original screenshots, or the linux/mac/windows table I have created?

zeljkofilipin added a comment.Aug 30 2016, 9:35 AM

@Elitre, @Esanders, @Amire80 Are the fonts now fixed? Images from the last build (on Windows) are here:

The last comments were a week ago. If there are no responses in the next day or two, I will resolve the task.

zeljkofilipin closed this task as Resolved.Aug 31 2016, 9:41 AM

Assuming the fonts are fine now. Please reopen if there are anything left to fix.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL