Because of T141366, Parsoid right now uses 2 different loggers: one provided and used by service-runner for logging service-runner events, and one Parsoid-internal logger to log Parsoid events. We need to fix this to use the same logger for both.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Arlolra | T141371 Use service-runner's config.yaml for all Parsoid configuration instead of relying on localsettings.js | |||
| Resolved | Arlolra | T141370 Use the same logger to log service-runner events and Parsoid events |
Event Timeline
Comment Actions
Not to mention that in cases where we aren't using service-runner (ie. other bins like parse.js) we still want to be able to log. See,
https://github.com/wikimedia/parsoid/commit/9d1df5e61c273b8c6a01b37b826aeb8aba1cf700 where we added js-yaml to support config.yaml in parse.js
I wonder if Services have a generic solution for this, like service-template-node or something.
Comment Actions
The most viable option would be to update service-runner to accept a logger as a config param.
Comment Actions
Change 305754 had a related patch set uploaded (by Arlolra):
T141370: Use service-runner's logger as a backend to Parsoid's logger
Comment Actions
Change 305754 merged by jenkins-bot:
T141370: Use service-runner's logger as a backend to Parsoid's logger
Comment Actions
We solved this by using service runner's logger as a backend to Parsoid's logger. I'm going to remove the dependency on T141366.