Page MenuHomePhabricator
Create Task
Maniphest T141378

Regression: Clear icon overlaps input text
Closed, ResolvedPublic
Actions

Description

Type a long search term on http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings#/search
You'll notice the clear icon overlaps the input text.

Screen Shot 2016-07-26 at 9.45.17 AM.png (700×397 px, 28 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make space for clear iconmediawiki/extensions/MobileFrontendmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 26 2016, 4:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2016, 4:46 PM
Jdlrobson renamed this task from Clear icon overlaps input text to Regression: Clear icon overlaps input text.Jul 26 2016, 4:46 PM
Jdlrobson added a project: Regression.
phuedx subscribed.Jul 26 2016, 4:51 PM

Highly likely due to T139928.

• Jhernandez added a project: Web-Team-Backlog-Archived.Jul 26 2016, 5:04 PM
• Jhernandez triaged this task as High priority.Jul 26 2016, 5:11 PM
• Jhernandez added a project: Reading-Web-Sprint-77-Segmentation-fault.
• Jhernandez moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-77-Segmentation-fault board.
• Jhernandez moved this task from Incoming to 2016-17 Q1 on the Web-Team-Backlog-Archived board.
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-77-Segmentation-fault board.Jul 26 2016, 5:33 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-77-Segmentation-fault board.Jul 26 2016, 5:39 PM
gerritbot subscribed.Jul 26 2016, 5:40 PM

Change 301173 had a related patch set uploaded (by Jdlrobson):
Make space for clear icon

https://gerrit.wikimedia.org/r/301173

Jdlrobson claimed this task.Jul 26 2016, 5:40 PM
MBinder_WMF added a parent task: T139928: Magnifying glass misaligned in Firefox on the language switcher overlay.Jul 26 2016, 8:42 PM
gerritbot added a comment.Jul 27 2016, 8:58 AM

Change 301173 merged by jenkins-bot:
Make space for clear icon

https://gerrit.wikimedia.org/r/301173

phuedx reassigned this task from Jdlrobson to dr0ptp4kt.Jul 27 2016, 9:00 AM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-77-Segmentation-fault board.
ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Jul 27 2016, 9:00 AM
phuedx added a subscriber: • Nirzar.Jul 27 2016, 9:22 AM

@Nirzar: I noted during my review of the change that you might want to review the padding around the clear button at low widths, i.e. 240px < $width < 480px.

• Nirzar added a comment.Jul 27 2016, 6:34 PM

Not getting this bug?

pasted_file (104×268 px, 8 KB)

what browser/os is used in the screenshot in the description?

Jdlrobson added a comment.Jul 27 2016, 7:06 PM

@Nirzar we already fixed it (see merge above). Sam is asking you specifically about what you think about the size of the icon on a 240px screen resolution.

• Nirzar added a comment.Jul 27 2016, 7:17 PM

ahh.. okay. yeah sam that's a good point.

pasted_file (104×193 px, 15 KB)

^^ the width is almost triple the width of the icon. i think we can shave off 2-3px on each side for smaller screens. not much of an issue for devices with 300px+ width

will that be another ticket or part of this ticket?

phuedx added a comment.Jul 28 2016, 6:33 AM

@Nirzar: Could you file it as a separate ticket? (I could too, obvs).

• Jhernandez closed this task as Resolved.Jul 29 2016, 10:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits