Page MenuHomePhabricator

Convert Examples extension to extension registration
Closed, ResolvedPublic

Description

These should've really been done first tbh.

The sub structure isn't great for this, but the 3 separate extensions underneath can/should be done. Then SpecialIncludeable too, which needs moving to it's own folder, and converting

Just something then needs doing for the combined entry point..

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Change 303387 had a related patch set uploaded (by Reedy):
Convert ContentAction example extension to extension registration

https://gerrit.wikimedia.org/r/303387

Reedy triaged this task as Lowest priority.Aug 6 2016, 10:44 PM

Change 303387 merged by jenkins-bot:
Convert ContentAction example extension to extension registration

https://gerrit.wikimedia.org/r/303387

@Reedy: As your patch is merged: Is more needed here or can this be resolved?

Yeah, more is needed.

The examples/Example and examples/DataPages "extensions" need converting. So does the "SpecialIncludable.php", which probably wants moving to it's own folder, and then the loader code moving to an extension.json instead of the PHP all in one

Samwilson added a subscriber: Samwilson.

I can do the DataPages one.

Change 406483 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/examples@master] Migrate DataPages to extension registration

https://gerrit.wikimedia.org/r/406483

Change 406483 merged by jenkins-bot:
[mediawiki/extensions/examples@master] Migrate DataPages to extension registration

https://gerrit.wikimedia.org/r/406483

@Reedy: *If* I understand correctly this was done in https://gerrit.wikimedia.org/r/406483 and https://gerrit.wikimedia.org/r/485348 ? ("if", hence asking.)
This allows using wfLoadExtension(s), right (as I'm coming here from T156568)?

Aklapper renamed this task from Convert Example extensions to extension registration to Convert Examples extension to extension registration.Aug 23 2020, 1:22 PM
Aklapper removed a project: Patch-For-Review.

Looks to be all done yeah