Page MenuHomePhabricator

[betalabs] Special: Notifications - incorrect day format timestamp is displayed
Closed, ResolvedPublic

Description

The timestamp for day format is displayed when notifications were triggered after 17:00 PDT.

Note: The issue seems to be happening only when notifications are sent after 17:00 PDT

  1. The notification from the screenshot (un-read 'Thanks') was recorded in db as
mysql> select * from echo_notification  where notification_event= 308002\G
*************************** 1. row ***************************
              notification_event: 308002
               notification_user: 6915
          notification_timestamp: 20160727002131
     notification_read_timestamp: NULL
        notification_bundle_base: 1
        notification_bundle_hash: ee5c469d9ccc7772b986dd2fb0f87dd2
notification_bundle_display_hash: 486bd88e3e6b59f185430768328f09a1
1 row in set (0.01 sec)

After some time and after frequent reloading the page (navigating away, refreshing, and re-login), the format of the timestamp is still displayed incorrectly.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2016, 1:07 AM

Change 300596 had a related patch set uploaded (by Mattflaschen):
BREAKING CHANGE: More ISO 8601 for seen time

https://gerrit.wikimedia.org/r/300596

To be precise, this happens if:

  • Your timezone offset from UTC is negative (so that midnight UTC occurs before midnight local time)
  • You receive a notification after midnight UTC (=5pm PDT)
  • You view Special:Notifications before midnight local time that same day

You will then see those notifications (correctly) grouped under the "Today" group, but the group title will (incorrectly) be YYYY-MM-DDT00:00:00Z-HH:MM rather than "Today". After midnight local time, the group title will (correctly) change to "Yesterday".

Change 300596 merged by jenkins-bot:
BREAKING CHANGE: More ISO 8601 for seen time

https://gerrit.wikimedia.org/r/300596

Etonkovidova updated the task description. (Show Details)Jul 27 2016, 4:41 PM

Checked the fix in betalabs - 1.28.0-alpha (86ffeb1)

jmatazzoni closed this task as Resolved.Aug 2 2016, 12:49 AM
jmatazzoni claimed this task.