On commons it is no longer possible for admins to grant " Upload Wizard campaign editor". Has this been changed accidentally? It was always possible for admins.
Description
Details
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Stalled | None | T141431 Can't grant "Upload Wizard campaign editor" unless default settings are customized | |||
Open | None | T123085 Set merge strategies for wgAddGroups and wgRemoveGroups |
Event Timeline
The permission is still available via UploadWizard extension.json#L45 and I do not see revokes via InitialiseSettings.php
It seems it may have broken around the time it was switched to extension registration
Interesting. I note that $wgAddGroups is overridden in InitialiseSettings:
'wgAddGroups' => [ ... '+commonswiki' => [ 'bureaucrat' => [ 'gwtoolset', 'ipblock-exempt', 'translationadmin' ], // T26374, T65124, T78814 'checkuser' => [ 'ipblock-exempt' ], 'sysop' => [ 'rollbacker', 'confirmed', 'patroller', 'autopatrolled', 'filemover', 'Image-reviewer' ], 'Image-reviewer' => [ 'Image-reviewer' ], ], ... ],
Perhaps things run in a different order now, and this overrides the setting from UploadWizard? I suppose we could just add it back.
Change 301371 had a related patch set uploaded (by Bartosz Dziewoński):
Add 'upwizcampeditors' to $wgAddGroups, $wgRemoveGroups for commonswiki
I scheduled this change for SWAT deployment in half an hour (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20160727T1500). It would be great if some Commons sysop could be on #wikimedia-operations on IRC at the time to verify that it's fixed.
Change 301371 merged by jenkins-bot:
Add 'upwizcampeditors' to $wgAddGroups, $wgRemoveGroups for commonswiki
This should now be fixed on Commons (but not on other wikis, if there are any using campaigns) – @Steinsplitter or anyone, can you please confirm?
(I would like to keep this open until we fix the defaults and can revert https://gerrit.wikimedia.org/r/301371.)