Page MenuHomePhabricator

Can't grant "Upload Wizard campaign editor" unless default settings are customized
Open, Stalled, LowPublic

Description

On commons it is no longer possible for admins to grant " Upload Wizard campaign editor". Has this been changed accidentally? It was always possible for admins.

Event Timeline

The permission is still available via UploadWizard extension.json#L45 and I do not see revokes via InitialiseSettings.php

It seems it may have broken around the time it was switched to extension registration

This is not commons: specific - see also test2wiki, same problem.

Interesting. I note that $wgAddGroups is overridden in InitialiseSettings:

'wgAddGroups' => [
	...
	'+commonswiki' => [
		'bureaucrat' => [ 'gwtoolset', 'ipblock-exempt', 'translationadmin' ], // T26374, T65124, T78814
		'checkuser' => [ 'ipblock-exempt' ],
		'sysop' => [ 'rollbacker', 'confirmed', 'patroller', 'autopatrolled', 'filemover', 'Image-reviewer' ],
		'Image-reviewer' => [ 'Image-reviewer' ],
	],
	...
],

Perhaps things run in a different order now, and this overrides the setting from UploadWizard? I suppose we could just add it back.

(It still works for me locally, so this has to be something specific to WMF config.)

Change 301371 had a related patch set uploaded (by Bartosz Dziewoński):
Add 'upwizcampeditors' to $wgAddGroups, $wgRemoveGroups for commonswiki

https://gerrit.wikimedia.org/r/301371

I scheduled this change for SWAT deployment in half an hour (https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20160727T1500). It would be great if some Commons sysop could be on #wikimedia-operations on IRC at the time to verify that it's fixed.

Change 301371 merged by jenkins-bot:
Add 'upwizcampeditors' to $wgAddGroups, $wgRemoveGroups for commonswiki

https://gerrit.wikimedia.org/r/301371

This should now be fixed on Commons (but not on other wikis, if there are any using campaigns) – @Steinsplitter or anyone, can you please confirm?

This should now be fixed on Commons (but not on other wikis, if there are any using campaigns) – @Steinsplitter or anyone, can you please confirm?

Works, thanks :-)

(I would like to keep this open until we fix the defaults and can revert https://gerrit.wikimedia.org/r/301371.)

matmarex renamed this task from Can't grant Upload Wizard campaign editor on commons to Can't grant "Upload Wizard campaign editor" on Commons unless default settings are customized.Jul 27 2016, 8:07 PM
matmarex triaged this task as Medium priority.
Dereckson lowered the priority of this task from Medium to Low.Dec 11 2016, 6:39 PM
matmarex changed the task status from Open to Stalled.Dec 11 2016, 9:57 PM

We're waiting for T123085 to be fixed.

matmarex renamed this task from Can't grant "Upload Wizard campaign editor" on Commons unless default settings are customized to Can't grant "Upload Wizard campaign editor" unless default settings are customized.Dec 11 2016, 9:57 PM
matmarex removed a project: Wikimedia-Site-requests.