Maniphest T141518

[Bug] Invalid calendar models in wbparsevalue are silently discarded
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• adrianheine
	Jul 28 2016, 12:39 PM

Tags

Referenced Files

None

Subscribers

• adrianheine

Lydia_Pintscher

View All 10 Subscribers

Description

See https://www.wikidata.org/w/api.php?action=wbparsevalue&datatype=time&values=1&options={%22calendar%22%3A%22broken%22}.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T87764 Bugs related to time datatype (tracking)
		Resolved		Addshore	T141518 [Bug] Invalid calendar models in wbparsevalue are silently discarded
		Resolved		Addshore	T204719 Use data-values/time 1.0.1 mediawiki-vendor for WMF production
		Resolved		Addshore	T204727 Make Wikibase extension installable with data-values/time ~1.0
		Resolved		Addshore	T204728 Make WikibaseQualityConstraints extension installable with data-value/time ~1.0

Event Timeline

• adrianheine created this task.Jul 28 2016, 12:39 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 28 2016, 12:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Bugreporter added a parent task: T87764: Bugs related to time datatype (tracking).Aug 3 2016, 8:46 PM

I agree. The relevant line of code is: https://github.com/DataValues/Time/blob/master/src/ValueParsers/IsoTimestampParser.php#L244. Instead it should throw an exception when an invalid calendar model is given.

Work in progress: https://github.com/DataValues/Time/pull/122

thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.Aug 3 2017, 6:38 PM

thiemowmde added projects: Patch-For-Review, Wikidata-Former-Sprint-Board.

thiemowmde added subscribers: Ladsgroup, Lydia_Pintscher, daniel.

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptAug 3 2017, 6:38 PM

thiemowmde edited projects, added patch-welcome, good first task; removed Wikidata-Former-Sprint-Board, Wikidata-Sprint-2016-09-21.Oct 24 2017, 4:27 PM

thiemowmde moved this task from consider for next sprint to ready to go on the Wikidata board.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptOct 24 2017, 4:27 PM

Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:41 PM

Liuxinyu970226 subscribed.Feb 11 2018, 2:51 PM

I just merged the PR in the library (2 years later....) https://github.com/DataValues/Time/pull/122

Looks like this just has to wait for the next release of the Time library now.

Addshore moved this task from ready to go to in progress on the Wikidata board.Sep 18 2018, 12:24 PM

Once the sub task has been resolved this task should be resolved.
So I'll mark this as stalled for now.

• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:49 AM

Addshore closed subtask T204719: Use data-values/time 1.0.1 mediawiki-vendor for WMF production as Resolved.Dec 13 2018, 5:27 PM

matej_suchanek closed this task as Resolved.Sep 21 2019, 12:16 PM

matej_suchanek assigned this task to Addshore.

matej_suchanek removed a project: Patch-For-Review.

Restricted Application added a project: User-Addshore. · View Herald TranscriptSep 21 2019, 12:16 PM