Warning: Invalid argument supplied for foreach() in classes/View.php on line 507
Closed, ResolvedPublic⚠
Actions

Description

I thought I had already filed this one but maybe I mixed up with another extension or even T96422/T37865.

[11-Jun-2018 16:52:54 UTC] PHP Warning:  Invalid argument supplied for foreach() in /srv/mediawiki/tags/2018-06-06_05:52:45/extensions/LiquidThreads/classes/View.php on line 505

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/LiquidThreads	wmf/1.35.0-wmf.3	+1 -1	Silence PHP warning in classes/View.php
	mediawiki/extensions/LiquidThreads	master	+1 -1	Silence PHP warning in classes/View.php

Customize query in gerrit

Related Objects

Mentioned Here: T37865: LQT: Invalid argument supplied for foreach()
T96422: PHP Warning: Invalid argument supplied for foreach() in LiquidThreads/classes/Hooks.php on line 944

Event Timeline

Nemo_bis created this task.Jul 28 2016, 4:49 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2016, 4:49 PM

Nemo_bis added a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Jul 28 2016, 4:50 PM

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.

Nemo_bis raised the priority of this task from Lowest to Medium.Aug 5 2016, 7:11 AM

Reedy renamed this task from Warning: Invalid argument supplied for foreach() in classes/View.php on line 471 to Warning: Invalid argument supplied for foreach() in classes/View.php on line 505.Jun 11 2018, 6:54 PM

Reedy merged a task: T196930: Invalid argument supplied for foreach() in /srv/[...]/extensions/LiquidThreads/classes/View.php on line 505.

Reedy updated the task description. (Show Details)

Reedy added a subscriber: • MarcoAurelio.

Recent sample:

Request ID: XRKyCgpAIDUAABjVY-cAAAAD

message

PHP Warning: Invalid argument supplied for foreach()

trace

#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/LiquidThreads/classes/View.php(507): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/LiquidThreads/api/ApiThreadAction.php(799): LqtView::getInlineEditForm(Article, string, NULL)
#2 /srv/mediawiki/php-1.34.0-wmf.10/extensions/LiquidThreads/api/ApiThreadAction.php(55): ApiThreadAction->actionInlineEditForm(array, array)
#3 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(1595): ApiThreadAction->execute()
#4 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(531): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.34.0-wmf.10/api.php(87): ApiMain->execute()

I checked this code, and can't figure out how is that supposed to work. The foreach iterates over $request->getSessionArray(), which will return null if $request->sessionId is unset. AFAICS, nothing in the LQT thread is initializing the sessionId, either by passing in a Session object or something like that. So, is $request->getSessionArray always null?! It could be due to some refactoring that was made in 2016, I guess...

mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM

Phabricator_maintenance added a project: affects-translatewiki.net.Sep 26 2019, 1:53 PM

Phabricator_maintenance removed a parent task: T41480: [DO NOT USE] Issues affecting translatewiki.net [superseded by #affects-translatewiki.net].Sep 26 2019, 1:55 PM

Nikerabbit renamed this task from Warning: Invalid argument supplied for foreach() in classes/View.php on line 505 to Warning: Invalid argument supplied for foreach() in classes/View.php on line 507.Oct 16 2019, 12:36 PM

Nikerabbit claimed this task.Oct 24 2019, 9:17 AM

Change 545781 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/LiquidThreads@master] Silence PHP warning in classes/View.php

https://gerrit.wikimedia.org/r/545781

gerritbot added a project: Patch-For-Review.Oct 24 2019, 9:17 AM

Change 545781 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Silence PHP warning in classes/View.php

https://gerrit.wikimedia.org/r/545781

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 24 2019, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 24 2019, 8:10 PM

Krinkle removed a subscriber: Krinkle.Oct 25 2019, 12:26 AM

Change 545984 had a related patch set uploaded (by Krinkle; owner: Nikerabbit):
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.3] Silence PHP warning in classes/View.php

https://gerrit.wikimedia.org/r/545984

gerritbot added a project: Patch-For-Review.Oct 25 2019, 12:27 AM

Change 545984 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.3] Silence PHP warning in classes/View.php

https://gerrit.wikimedia.org/r/545984

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.3; 2019-10-22); removed MW-1.35-notes (1.35.0-wmf.4; 2019-10-29).Oct 25 2019, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2019, 1:10 AM