Description
Details
Related Objects
Event Timeline
LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.
Recent sample:
- Request ID: XRKyCgpAIDUAABjVY-cAAAAD
PHP Warning: Invalid argument supplied for foreach()
#0 /srv/mediawiki/php-1.34.0-wmf.10/extensions/LiquidThreads/classes/View.php(507): MWExceptionHandler::handleError(integer, string, string, integer, array, array) #1 /srv/mediawiki/php-1.34.0-wmf.10/extensions/LiquidThreads/api/ApiThreadAction.php(799): LqtView::getInlineEditForm(Article, string, NULL) #2 /srv/mediawiki/php-1.34.0-wmf.10/extensions/LiquidThreads/api/ApiThreadAction.php(55): ApiThreadAction->actionInlineEditForm(array, array) #3 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(1595): ApiThreadAction->execute() #4 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(531): ApiMain->executeAction() #5 /srv/mediawiki/php-1.34.0-wmf.10/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling() #6 /srv/mediawiki/php-1.34.0-wmf.10/api.php(87): ApiMain->execute()
I checked this code, and can't figure out how is that supposed to work. The foreach iterates over $request->getSessionArray(), which will return null if $request->sessionId is unset. AFAICS, nothing in the LQT thread is initializing the sessionId, either by passing in a Session object or something like that. So, is $request->getSessionArray always null?! It could be due to some refactoring that was made in 2016, I guess...
Change 545781 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/LiquidThreads@master] Silence PHP warning in classes/View.php
Change 545781 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Silence PHP warning in classes/View.php
Change 545984 had a related patch set uploaded (by Krinkle; owner: Nikerabbit):
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.3] Silence PHP warning in classes/View.php
Change 545984 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@wmf/1.35.0-wmf.3] Silence PHP warning in classes/View.php