Maniphest T141559

Convert specialcreatecollaborationhub to use ooui for consistency with other widgets
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Isarra
	Jul 28 2016, 7:37 PM

Tags

Subscribers

Description

This is as simple as getting rid of

protected function alterForm( HTMLForm $form ) {
	$form->setDisplayFormat( 'div' );
	$form->setWrapperLegend( false );
}

and replacing it with:

protected function getDisplayFormat() {
	return 'ooui';
}

...unfortunately hide-if doesn't currently work in ooui (T141558), so the source field shows up even when there's no content import selected.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CollaborationKit	master	+541 -1 K	Refactor CollaborationHubContent etc to reflect Hubs as only mainpages

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Isarra	T141559 Convert specialcreatecollaborationhub to use ooui for consistency with other widgets
		Resolved		matmarex	T141558 hide-if doesn't work in OOUI HTMLForm

Event Timeline

Isarra created this task.Jul 28 2016, 7:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2016, 7:37 PM

Isarra added a subtask: T141558: hide-if doesn't work in OOUI HTMLForm.Jul 28 2016, 7:39 PM

Isarra moved this task from In Progress to Release blockers on the MediaWiki-extensions-CollaborationKit board.Jul 29 2016, 12:16 AM

Change 302971 had a related patch set uploaded (by Isarra):
Refactor CollaborationHubContent etc to reflect Hubs as only mainpages

https://gerrit.wikimedia.org/r/302971

gerritbot added a project: Patch-For-Review.Aug 4 2016, 9:15 PM

Isarra mentioned this in rECKT48ac512b861e: Refactor CollaborationHubContent etc to reflect Hubs as only mainpages.Aug 4 2016, 9:16 PM

Harej moved this task from Release blockers to In Progress on the MediaWiki-extensions-CollaborationKit board.Aug 4 2016, 9:21 PM

Isarra mentioned this in rECKT9a004280ca8a: Refactor CollaborationHubContent etc to reflect Hubs as only mainpages.Aug 4 2016, 9:40 PM

Isarra mentioned this in rECKT9b721161d69f: Refactor CollaborationHubContent etc to reflect Hubs as only mainpages.Aug 4 2016, 9:48 PM

Isarra mentioned this in rECKT60d1a67ce5de: Refactor CollaborationHubContent etc to reflect Hubs as only mainpages.Aug 4 2016, 9:54 PM

Isarra mentioned this in rECKTea39807891d5: Refactor CollaborationHubContent etc to reflect Hubs as only mainpages.Aug 4 2016, 9:57 PM

Isarra mentioned this in rECKT91ed95d8eacf: Refactor CollaborationHubContent etc to reflect Hubs as only mainpages.Aug 4 2016, 10:20 PM

It uses it. We should still keep an eye on T141558 since it kind of needs that, of course.

Change 302971 merged by jenkins-bot:
Refactor CollaborationHubContent etc to reflect Hubs as only mainpages

https://gerrit.wikimedia.org/r/302971

Harej moved this task from In Progress to Done on the MediaWiki-extensions-CollaborationKit board.Aug 5 2016, 11:31 AM

matmarex closed subtask T141558: hide-if doesn't work in OOUI HTMLForm as Resolved.Aug 22 2016, 4:09 PM