Page MenuHomePhabricator

Changing app language does not automatically update the explore feed language
Closed, ResolvedPublic1 Estimated Story Points

Description

In the Explore feed screen of the Android app, if I change the language, the Explore feed does not auto update to the new language

Scenario A: Change languages in Settings:

Steps to reproduce

  1. Open the app to the Explore feed, note the language the app is set to for card content in the feed
  2. Go to Settings and change the Wikipedia languages
  3. Return to the feed do not pull down to refresh the feed

Scenario B: Change languages during app onboarding

Pre-conditions: App language settings are changed within the onboarding flow
Steps to reproduce

  1. Open the app onboarding to the 2nd step and select to "Add or Edit languages"
  2. Go to Settings and change the Wikipedia languages
  3. Return to finish the onboarding screens to see the feed appear after tapping GET STARTED on the last app onboarding step. do not pull down to refresh the feed

Scenario C: Change languages during search

Steps to reproduce

  1. Open the app to the Explore feed, note the language the app is set to for card content in the feed, eg 1/EN, 2/ZH-HANT
  2. Open Search. Tap on "MORE" to change the Wikipedia languages, for example, remove 2/ZH-HANT and replace with 2/DE (German)
  3. Return to the feed do not pull down to refresh the feed (It is expected the feed should shown content in English and German)

Expected

Feed has updated to show content in the newly selected languages (note that UI text remains the same as the device language)

Actual

Feed needs to be pulled down to refresh the content.

Occurring on

Pixel 2 (8.0.1) on Wikipedia 2.7.227-alpha-2018-03-23

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

After you change the language, you can refresh the feed by swiping down (at the top of the feed), and you should see the new language take effect.
But you're right; this should probably happen automatically.

@Dbrant Just want to confirm that this is actually Android-app-feature-Navigation , since it arrived in triage with that tag.

Dbrant set the point value for this task to 1.Sep 2 2016, 6:38 PM
Niedzielski renamed this task from Switching language dies not auto change app's trending list to Changing app language does not automatically update the explore feed language.Mar 11 2017, 4:51 PM
Niedzielski updated the task description. (Show Details)

Change 437526 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Update Feed contents when language has changed from Settings or Search.

https://gerrit.wikimedia.org/r/437526

Change 437526 merged by jenkins-bot:
[apps/android/wikipedia@master] Update Feed contents when language has changed from Settings or Search.

https://gerrit.wikimedia.org/r/437526

ABorbaWMF added a subscriber: ABorbaWMF.

Scenarios A and B look good to me on 2.7.234-alpha-2018-06-07

I am having trouble reproducing Scenario C. Here is what I am seeing.

Steps:

  1. Setup the wikipedia app with English and Chinese (ZH-HANS) in positions 1 and 2 respectively
  2. Look at the explore feed, it is currently English
  3. Tap search and tap Chinese in the language chooser
  4. Tap back

At this point, the explore feed is still in English even after refresh. @RHo, Is this incorrect?

Oh actually whoops @ABorbaWMF - Scenario C *is* actually working! Here's a clarification on the steps:
Scenario C.

  1. Open the app to the Explore feed, note the language the app is set to for card content in the feed, eg 1/EN, 2/ZH-HANT
  2. Open Search. Tap on "MORE" to change the Wikipedia languages, for example, remove 2/ZH-HANT and replace with 2/DE (German)
  3. Return to the feed do not pull down to refresh the feed

It is expected that the feed should show content in English and German.

Scenarios A and B look good to me on 2.7.234-alpha-2018-06-07

I am having trouble reproducing Scenario C. Here is what I am seeing.

Steps:

  1. Setup the wikipedia app with English and Chinese (ZH-HANS) in positions 1 and 2 respectively
  2. Look at the explore feed, it is currently English
  3. Tap search and tap Chinese in the language chooser
  4. Tap back

At this point, the explore feed is still in English even after refresh. @RHo, Is this incorrect?

Hi @Dbrant @ABorbaWMF - I am not getting the refresh on the feed in Scenario B however:
https://youtu.be/fRCbE8FXu08

Change 440028 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Follow up: Should refresh the Feed content after finishing the initial onboarding

https://gerrit.wikimedia.org/r/440028

@RHo

  1. In my follow up patch, it will stop pre-loading the Feed content and navigate to the onboarding screen. The Feed content will be loaded for the first time once user exits the onboarding screen and returns to the Explore Feed page. (whether or not the user has changed the Wikipedia languages in the onboarding screen)
  1. In our current production, the Feed content will be loaded before entering the onboarding screen.

Just want to make sure which one is good to you. If you'd like to keep the 2. way, then I will make another update to the patch.

Thanks!

hi @cooltey - just had a look at your patch and this works for me, as do the other scenarios on this ticket. Please feel free to move back to QA directly once it's merged to the Alpha. Thanks!

I just noted an issue with this in version 2.7.234-alpha-2018-06-14 of the app. It seems that the feed is getting refreshed regardless of whether the languages are changed or not. To be precise the feed is refreshed unnecessarily in the following cases:

Scenario D: DO NOT change languages in Settings:

  1. Open the app to the Explore feed, note the language the app is set to for card content in the feed
  2. Go to Settings and open the 'Wikipedia language' menu but do not change the Wikipedia languages
  3. Return to the feed do not pull down to refresh the feed

Scenario E: DO NOT change languages during search

  1. Open the app to the Explore feed, note the language the app is set to for card content in the feed, eg 1/EN, 2/ZH-HANT
  2. Open Search. Tap on "MORE" but do not to change the Wikipedia languages
  3. Return to the feed do not pull down to refresh the feed

Change 440028 merged by jenkins-bot:
[apps/android/wikipedia@master] Follow up: Should refresh the Feed content after finishing the initial onboarding

https://gerrit.wikimedia.org/r/440028