Changing app language does not automatically update the explore feed language
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In the Explore feed screen of the Android app, if I change the language, the Explore feed does not auto update to the new language

Scenario A: Change languages in Settings:

Steps to reproduce

Open the app to the Explore feed, note the language the app is set to for card content in the feed
Go to Settings and change the Wikipedia languages
Return to the feed do not pull down to refresh the feed

Scenario B: Change languages during app onboarding

Pre-conditions: App language settings are changed within the onboarding flow
Steps to reproduce

Open the app onboarding to the 2nd step and select to "Add or Edit languages"
Go to Settings and change the Wikipedia languages
Return to finish the onboarding screens to see the feed appear after tapping GET STARTED on the last app onboarding step. do not pull down to refresh the feed

Scenario C: Change languages during search

Steps to reproduce

Open the app to the Explore feed, note the language the app is set to for card content in the feed, eg 1/EN, 2/ZH-HANT
Open Search. Tap on "MORE" to change the Wikipedia languages, for example, remove 2/ZH-HANT and replace with 2/DE (German)
Return to the feed do not pull down to refresh the feed (It is expected the feed should shown content in English and German)

Expected

Feed has updated to show content in the newly selected languages (note that UI text remains the same as the device language)

Actual

Feed needs to be pulled down to refresh the content.

Occurring on

Pixel 2 (8.0.1) on Wikipedia 2.7.227-alpha-2018-03-23

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Follow up: Should refresh the Feed content after finishing the initial onboarding	apps/android/wikipedia	master	+37 -31
	Update Feed contents when language has changed from Settings or Search.	apps/android/wikipedia	master	+53 -23

Customize query in gerrit

Related Objects

Mentioned In: T198385: Feed should be refreshed only when the *changing* the app languages
T196004: Refresh the Explore feed after logged in
T195413: "Today's featured article" card is not shown for other languages
T172568: [BUG] User may be directed to unrelated content from the "featured article" widget if device and app language are different
T159039: Changing the language of the app deosn't seem displaying text in new language in all places immediately

Event Timeline

Yurik created this task.Jul 28 2016, 11:36 PM

Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptJul 28 2016, 11:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

After you change the language, you can refresh the feed by swiping down (at the top of the feed), and you should see the new language take effect.
But you're right; this should probably happen automatically.

Dbrant moved this task from Needs Triage to Product Backlog on the Wikipedia-Android-App-Backlog board.Jul 29 2016, 8:11 PM

@Dbrant Just want to confirm that this is actually Android-app-feature-Navigation , since it arrived in triage with that tag.

MBinder_WMF unsubscribed.Aug 25 2016, 6:19 PM

Dbrant set the point value for this task to 1.Sep 2 2016, 6:38 PM

• Niedzielski renamed this task from Switching language dies not auto change app's trending list to Changing app language does not automatically update the explore feed language.Mar 11 2017, 4:51 PM

• Niedzielski updated the task description. (Show Details)

• Mholloway subscribed.Mar 14 2017, 4:45 PM

RHo mentioned this in T159039: Changing the language of the app deosn't seem displaying text in new language in all places immediately.Apr 6 2017, 3:28 PM

RHo merged a task: T159039: Changing the language of the app deosn't seem displaying text in new language in all places immediately.Mar 26 2018, 5:27 PM

RHo added subscribers: Kaartic, RHo, • Niedzielski.

• Mholloway unsubscribed.Mar 26 2018, 6:27 PM

RHo moved this task from Product Backlog to Bug Backlog on the Wikipedia-Android-App-Backlog board.Mar 27 2018, 3:27 PM

RHo edited projects, added Android-app-Bugs; removed Android-app-feature-Navigation.Mar 27 2018, 3:30 PM

RHo updated the task description. (Show Details)

RHo added a project: Android-app-feature-Multilingual.Mar 29 2018, 1:39 PM

LGoto edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly); removed Wikipedia-Android-App-Backlog.Apr 17 2018, 4:48 PM

Dbrant claimed this task.Apr 19 2018, 3:59 PM

Dbrant moved this task from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.

Dbrant moved this task from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.May 1 2018, 6:57 PM

RHo mentioned this in T172568: [BUG] User may be directed to unrelated content from the "featured article" widget if device and app language are different.May 22 2018, 4:33 PM

RHo updated the task description. (Show Details)May 22 2018, 4:38 PM

Kaartic unsubscribed.May 23 2018, 7:02 PM

Dbrant merged a task: T195413: "Today's featured article" card is not shown for other languages.May 24 2018, 7:49 PM

Dbrant added a subscriber: Kaartic.

Kaartic mentioned this in T195413: "Today's featured article" card is not shown for other languages.May 25 2018, 9:05 AM

RHo moved this task from Code Review to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.May 30 2018, 3:55 PM

cooltey mentioned this in T196004: Refresh the Explore feed after logged in.May 30 2018, 7:13 PM

Change 437526 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Update Feed contents when language has changed from Settings or Search.

https://gerrit.wikimedia.org/r/437526

gerritbot added a project: Patch-For-Review.Jun 5 2018, 6:19 PM

Dbrant moved this task from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 5 2018, 7:50 PM

Change 437526 merged by jenkins-bot:
[apps/android/wikipedia@master] Update Feed contents when language has changed from Settings or Search.

https://gerrit.wikimedia.org/r/437526

• Sharvaniharan moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 6 2018, 8:29 AM

RHo updated the task description. (Show Details)Jun 6 2018, 9:38 AM

Scenarios A and B look good to me on 2.7.234-alpha-2018-06-07

I am having trouble reproducing Scenario C. Here is what I am seeing.

Steps:

Setup the wikipedia app with English and Chinese (ZH-HANS) in positions 1 and 2 respectively
Look at the explore feed, it is currently English
Tap search and tap Chinese in the language chooser
Tap back

At this point, the explore feed is still in English even after refresh. @RHo, Is this incorrect?

hi @ABorbaWMF - you're correct, Scenario C has not been fixed.

Oh actually whoops @ABorbaWMF - Scenario C *is* actually working! Here's a clarification on the steps:
Scenario C.

Open the app to the Explore feed, note the language the app is set to for card content in the feed, eg 1/EN, 2/ZH-HANT
Open Search. Tap on "MORE" to change the Wikipedia languages, for example, remove 2/ZH-HANT and replace with 2/DE (German)
Return to the feed do not pull down to refresh the feed

It is expected that the feed should show content in English and German.

In T141587#4266393, @ABorbaWMF wrote:

Scenarios A and B look good to me on 2.7.234-alpha-2018-06-07

I am having trouble reproducing Scenario C. Here is what I am seeing.

Steps:

Setup the wikipedia app with English and Chinese (ZH-HANS) in positions 1 and 2 respectively

Look at the explore feed, it is currently English

Tap search and tap Chinese in the language chooser

Tap back

At this point, the explore feed is still in English even after refresh. @RHo, Is this incorrect?

Hi @Dbrant @ABorbaWMF - I am not getting the refresh on the feed in Scenario B however:
https://youtu.be/fRCbE8FXu08

RHo updated the task description. (Show Details)Jun 8 2018, 8:27 AM

cooltey moved this task from Did not pass QA to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 12 2018, 4:08 PM

Change 440028 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Follow up: Should refresh the Feed content after finishing the initial onboarding

https://gerrit.wikimedia.org/r/440028

cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.Jun 12 2018, 11:34 PM

@RHo

In my follow up patch, it will stop pre-loading the Feed content and navigate to the onboarding screen. The Feed content will be loaded for the first time once user exits the onboarding screen and returns to the Explore Feed page. (whether or not the user has changed the Wikipedia languages in the onboarding screen)

In our current production, the Feed content will be loaded before entering the onboarding screen.

Just want to make sure which one is good to you. If you'd like to keep the 2. way, then I will make another update to the patch.

Thanks!

hi @cooltey - just had a look at your patch and this works for me, as do the other scenarios on this ticket. Please feel free to move back to QA directly once it's merged to the Alpha. Thanks!

I just noted an issue with this in version 2.7.234-alpha-2018-06-14 of the app. It seems that the feed is getting refreshed regardless of whether the languages are changed or not. To be precise the feed is refreshed unnecessarily in the following cases:

Scenario D: DO NOT change languages in Settings:

Open the app to the Explore feed, note the language the app is set to for card content in the feed
Go to Settings and open the 'Wikipedia language' menu but do not change the Wikipedia languages
Return to the feed do not pull down to refresh the feed

Scenario E: DO NOT change languages during search

Open the app to the Explore feed, note the language the app is set to for card content in the feed, eg 1/EN, 2/ZH-HANT
Open Search. Tap on "MORE" but do not to change the Wikipedia languages
Return to the feed do not pull down to refresh the feed

Change 440028 merged by jenkins-bot:
[apps/android/wikipedia@master] Follow up: Should refresh the Feed content after finishing the initial onboarding