Page MenuHomePhabricator
Create Task
Maniphest T141647

[Regression] Fix browser tests for language switching on the beta cluster
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Not a regression in the language switcher or the button.

On the beta cluster we run the full set of browser tests. Currently these are failing since https://gerrit.wikimedia.org/r/#/c/301351/9
They are failing because the LocalSettings.php does not get loaded on the beta cluster.

A/C

Details

SubjectRepoBranchLines +/-
Fix the browser test failuresmediawiki/extensions/MobileFrontendmaster+11 -5
Enable new language bar on beta clusteroperations/mediawiki-configmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 29 2016, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2016, 6:29 PM
Jdlrobson updated the task description. (Show Details)Jul 29 2016, 6:30 PM
gerritbot subscribed.Jul 29 2016, 6:33 PM

Change 301858 had a related patch set uploaded (by Jdlrobson):
Fix the browser test failures

https://gerrit.wikimedia.org/r/301858

Jdlrobson updated the task description. (Show Details)Jul 29 2016, 6:40 PM
gerritbot added a comment.Jul 29 2016, 6:40 PM

Change 301861 had a related patch set uploaded (by Jdlrobson):
Enable new language bar on beta cluster

https://gerrit.wikimedia.org/r/301861

gerritbot added a comment.Jul 29 2016, 6:57 PM

Change 301861 merged by jenkins-bot:
Enable new language bar on beta cluster

https://gerrit.wikimedia.org/r/301861

Jdlrobson closed this task as Resolved.Aug 1 2016, 4:14 PM
Jdlrobson claimed this task.

Build 99 is passing https://integration.wikimedia.org/ci/view/Mobile/job/selenium-MobileFrontend/99/ after the config change.

Jdlrobson added projects: Reading-Web-Sprint-77-Segmentation-fault, Unplanned-Sprint-Work.Aug 1 2016, 4:14 PM
MBinder_WMF renamed this task from Fix browser tests for language switching on the beta cluster to [Regression] Fix browser tests for language switching on the beta cluster.Aug 1 2016, 4:14 PM
MBinder_WMF reopened this task as Open.
MBinder_WMF removed Jdlrobson as the assignee of this task.
MBinder_WMF triaged this task as High priority.
MBinder_WMF added projects: Web-Team-Backlog, Regression.
MBinder_WMF updated the task description. (Show Details)
MBinder_WMF set the point value for this task to 1.
MBinder_WMF moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-78-Terminal-Velocity board.
Jdlrobson claimed this task.Aug 1 2016, 4:15 PM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Reading-Web-Sprint-77-Segmentation-fault board.
Jdlrobson moved this task from To Do to Ready for Signoff on the Reading-Web-Sprint-78-Terminal-Velocity board.
phuedx reassigned this task from Jdlrobson to dr0ptp4kt.Aug 1 2016, 4:42 PM
phuedx updated the task description. (Show Details)
MBinder_WMF moved this task from Incoming to 2016-17 Q1 on the Web-Team-Backlog board.Aug 1 2016, 4:43 PM
• jhobs added subscribers: phuedx, • jhobs.Aug 1 2016, 5:32 PM

@Jdlrobson @phuedx Is https://gerrit.wikimedia.org/r/301858 part of this task? It's marked with the bug, yet not merged despite this task being Ready for Signoff.

gerritbot added a comment.Aug 1 2016, 5:49 PM

Change 301858 abandoned by Jdlrobson:
Fix the browser test failures

https://gerrit.wikimedia.org/r/301858

Jdlrobson added a comment.Aug 1 2016, 5:49 PM

No. It wasn't needed. I forgot to abandon after realising I was going down the wrong rabbit hole. This task is merged and just needs sign off.

phuedx added a comment.Aug 2 2016, 11:19 AM

@dr0ptp4kt: selenium-MobileFrontend is/was the affected job.

dr0ptp4kt added a subscriber: • bmansurov.Aug 2 2016, 5:07 PM

@phuedx, @jhobs, @bmansurov for your engineer signoff.

• jhobs claimed this task.Aug 2 2016, 5:28 PM
• jhobs added a subscriber: dr0ptp4kt.

A new build is running at the moment due to what seems like an API failure. I'll sign off if everything is green when it has finished.

phuedx moved this task from Ready for Signoff to -1 (Needs More Work) on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 3 2016, 5:32 AM
phuedx added a comment.Aug 3 2016, 11:19 AM

All scenarios are failing with the error described in T129483.

Jdlrobson added a comment.Aug 3 2016, 7:45 PM

See T129483. This is not only a problem with us but with other extensions. Early theories are no longer valid. Not sure what's going on here.

phuedx moved this task from -1 (Needs More Work) to Ready for Signoff on the Reading-Web-Sprint-78-Terminal-Velocity board.Aug 4 2016, 3:08 AM
phuedx changed the task status from Open to Stalled.Aug 4 2016, 3:19 AM

Per T141647#2520376

phuedx added a comment.Aug 8 2016, 9:02 AM

The last four builds are green. Per the AC, this is Resolved.

• jhobs closed this task as Resolved.Aug 11 2016, 4:55 PM
• jhobs removed • jhobs as the assignee of this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL