We should include the protocol in the ajax popup for shortened URLs and Special:UrlShortener.
Description
Details
Event Timeline
Hello @Legoktm could you please elaborate the description more. How can anyone reproduce the setting of the error, which extension is it about what, what do we need to clone etc?
Thanks for your interest! This is about the UrlShortener extension (see "Tags" on the right).
See https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker for how to set up a development environment and how to clone a codebase.
Hello @Aklapper and @Legoktm , I tried to reproduce the setting and installed the UrlShortener extension via using the vagrant way, as explained on the extension page. However, I do not see any ajax popup during the shortening process. A clear explanation of how to encounter the issue would be helpful.
Setting task status to stalled until @Legoktm elaborates via . Please reset the task status to open via Add Action... → Change Status - thanks!
I've checked out this bug and I think @Legoktm means that when a URL is provided in the input field whose domain is not supported, the Ajax popup will show a message without the protocol available for this URL. For example;
- If someone inputs "https://www.mediawiki.org/wiki/Extension:UrlShortener" which is not allowed (on localhost) for the domains to be shortened, a message like this will popup URLs to domain www.mediawiki.org are not allowed to be shortened.
- Instead the message should be URLs to domain https://www.mediawiki.org are not allowed to be shortened.
Looking at the extensions/UrlShortener/modules/ext.urlShortener.special.js on L55-L56, urlshortener-error-disallowed-url is being parsed and only host is fed into it. I presume both the host and the protocol attached to the host should be fed into mw.msg().
If at all this is what @Legoktm meant, then this should be easy to fix I think. @Legoktm, can you please confirm? Thanks
Change 418869 had a related patch set uploaded (by Rg4amia; owner: Rg4amia):
[mediawiki/extensions/UrlShortener@master] Show domain protocol in Ajax popup
I'm assigning to you as you submitted a patch that is pending review. Thanks so much and next time, when working on a task, assign it to yourself on phabricator. :)
Change 418869 abandoned by Aklapper:
Show domain protocol in Ajax popup
Reason:
Abandoning - superseded by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UrlShortener/ /420380/
Change 420380 had a related patch set uploaded (by D3r1ck01; owner: Rg4amia):
[mediawiki/extensions/UrlShortener@master] Show domain protocol in Ajax popup
Change 420380 had a related patch set uploaded (by Ammarpad; owner: Rg4amia):
[mediawiki/extensions/UrlShortener@master] Show domain protocol in Ajax popup
Change 420380 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Show domain protocol in Ajax popup