Page MenuHomePhabricator

GerritBot not always commenting on changes in Phabricator tasks
Closed, InvalidPublic

Description

Sometimes i notice gerrit bot not adding patch for review or sometimes not even commenting on changes that include a phabricator task at all or is very delayed. I suggest fixing this so that way developers don't have to assume that there was not patch uploaded or have to dig through thousands of commit to find the one they are looking for.

Event Timeline

Zppix edited projects, added GerritBot; removed Gerrit.

sometimes not even commenting on changes that include a phabricator task

Can you give any examples of this happening?

T141743, gerrit bot was delayed majorly I had to post about the change and add the patch review tag manually.

Aklapper renamed this task from Gerrit Bot not functioning properly on phabricator to GerritBot not always commenting on changes in Phabricator tasks.Aug 2 2016, 4:54 PM
Zppix triaged this task as High priority.Aug 2 2016, 4:56 PM

The patch for review bit (cf: T141448) is definitely a bug, trying to figure that out now.

For the "waiting a long time" I can't actually replicate it. T141065: Fine-tune gerrit cache settings updated immediately upon me adding a task to the commit message, and tracing the log shows it happening quite often for other tasks too.

As far as T141743 is concerned, I believe there's a misunderstanding. The original commit message didn't have the Bug: T1234 format. The second patch set does, at which point the task updated immediately. This is expected behavior, if somewhat confusing at times. There's a task about this: T91001.